Issue 221150043: Major files refactoring - isolate.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 221150043: Major files refactoring - isolate. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years ago by M-A

Modified:
9 years ago

Reviewers:
vadimsh

CC:
swarming-eng_googlegroups.com, nodir_chromium, iannucci

Base URL:
https://code.google.com/p/swarming@master

Visibility:
Public.

More Reviews

Description

Major files refactoring - isolate. - Split main from handlers declaration for endpoints handlers. - Remove unnecessary imports. - Remove APP from mapreduce_jobs, it unnecessary. - Rename source files for consistency. - Enforce debug parameter on all create_application(). - Remove appstats, the new Cloud Console Trace features can give meaningful data without require intervention from within the app. R=vadimsh@chromium.org BUG= Committed: https://code.google.com/p/swarming/source/detail?repo=default&r=2c2176043b7396a4ae494e7bc1c98491180f306d

Patch Set 1 #

Total comments: 2

Patch Set 2 : Bug fix #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+106 lines, -1124 lines)			Patch
M	appengine/isolate/app.yaml	View	1	2 chunks	+4 lines, -5 lines	0 comments	Download
M	appengine/isolate/appengine_config.py	View		1 chunk	+1 line, -2 lines	0 comments	Download
D	appengine/isolate/endpoint_handlers_api.py	View		1 chunk	+0 lines, -472 lines	0 comments	Download
D	appengine/isolate/endpoint_handlers_api_test.py	View		1 chunk	+0 lines, -529 lines	0 comments	Download
M	appengine/isolate/handlers_backend.py	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	appengine/isolate/handlers_endpoints.py	View		3 chunks	+6 lines, -24 lines	0 comments	Download
A +	appengine/isolate/handlers_endpoints_test.py	View		20 chunks	+58 lines, -46 lines	0 comments	Download
M	appengine/isolate/handlers_frontend.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	appengine/isolate/main_backend.py	View		2 chunks	+9 lines, -17 lines	0 comments	Download
M	appengine/isolate/main_frontend.py	View		1 chunk	+19 lines, -19 lines	0 comments	Download
M	appengine/isolate/mapreduce_jobs.py	View		2 chunks	+6 lines, -6 lines	0 comments	Download
M	appengine/isolate/module-backend.yaml	View		2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

vadimsh

lgtm with a minor fix https://codereview.appspot.com/221150043/diff/1/appengine/isolate/app.yaml File appengine/isolate/app.yaml (right): https://codereview.appspot.com/221150043/diff/1/appengine/isolate/app.yaml#newcode16 appengine/isolate/app.yaml:16: script: main_frontend.endpoint_ap endpoints_app

9 years ago (2015-03-26 21:31:46 UTC) #2

M-A

https://codereview.appspot.com/221150043/diff/1/appengine/isolate/app.yaml File appengine/isolate/app.yaml (right): https://codereview.appspot.com/221150043/diff/1/appengine/isolate/app.yaml#newcode16 appengine/isolate/app.yaml:16: script: main_frontend.endpoint_ap On 2015/03/26 21:31:46, vadimsh wrote: > endpoints_app ...

9 years ago (2015-03-27 14:07:44 UTC) #3

M-A

9 years ago (2015-03-27 14:09:22 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
2c2176043b7396a4ae494e7bc1c98491180f306d (presubmit successful).

Expand All Messages | Collapse All Messages