Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(540)

Issue 220090043: Fix issue 4040: Dots ignoring shifted ledger lines (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years ago by pwm
Modified:
8 years, 12 months ago
Reviewers:
pkx166h, david.nalesnik
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fix issue 4040: Dots ignoring shifted ledger lines includes the following two commits: add test staff-ledger-positions-dotted-notes.ly tests positioning of dots on dotted notes with custom ledger line positions (issue 4040) staff-symbol.cc: on_line and custom ledger lines make Staff_symbol::on_line work properly with custom ledger line positions

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -28 lines) Patch
A input/regression/staff-ledger-positions-dotted-notes.ly View 1 chunk +16 lines, -0 lines 2 comments Download
M lily/staff-symbol.cc View 2 chunks +31 lines, -28 lines 0 comments Download

Messages

Total messages: 8
pwm
Please review, thanks! -Paul
9 years ago (2015-03-23 03:45:42 UTC) #1
pkx166h
Patch on countdown for March 28th
9 years ago (2015-03-25 20:07:44 UTC) #2
david.nalesnik
Aside from whitespace issue, LGTM. I assume this could be fixed when pushing, and there's ...
9 years ago (2015-03-26 17:21:38 UTC) #3
pwm
https://codereview.appspot.com/220090043/diff/1/input/regression/staff-ledger-positions-dotted-notes.ly File input/regression/staff-ledger-positions-dotted-notes.ly (right): https://codereview.appspot.com/220090043/diff/1/input/regression/staff-ledger-positions-dotted-notes.ly#newcode2 input/regression/staff-ledger-positions-dotted-notes.ly:2: On 2015/03/26 17:21:38, david.nalesnik wrote: > minor nit: trailing ...
9 years ago (2015-03-27 04:13:34 UTC) #4
pwm
On 2015/03/26 17:21:38, david.nalesnik wrote: > Aside from whitespace issue, LGTM. I assume this could ...
9 years ago (2015-03-27 04:50:36 UTC) #5
pkx166h
On 2015/03/27 04:50:36, pwm wrote: > On 2015/03/26 17:21:38, david.nalesnik wrote: > > Aside from ...
9 years ago (2015-03-27 12:29:14 UTC) #6
pkx166h
Patch counted down - please push (make sure you fix the trailing white spaces)
9 years ago (2015-03-28 08:23:25 UTC) #7
pkx166h
9 years ago (2015-03-28 16:45:24 UTC) #8
author	Paul Morris <paulwmorris@gmail.com>	
	Fri, 20 Mar 2015 04:27:20 +0000 (00:27 -0400)
committer	James Lowe <pkx166h@gmail.com>	
	Sat, 28 Mar 2015 16:40:48 +0000 (16:40 +0000)
commit	ccb42361aa4ad49c07d5c76b1feab3d6647dc159

and

author	Paul Morris <paulwmorris@gmail.com>	
	Fri, 20 Mar 2015 04:34:31 +0000 (00:34 -0400)
committer	James Lowe <pkx166h@gmail.com>	
	Sat, 28 Mar 2015 16:42:51 +0000 (16:42 +0000)
commit	c2e7e635eb84f635b0134f93aa27a11db06e4677

Thanks Paul
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b