Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(563)

Issue 21990046: Make licensecheck.pl happy by tweaking the license header. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by M-A
Modified:
11 years, 8 months ago
Reviewers:
vadimsh
CC:
swarming-eng_googlegroups.com, csharp+cc_chromium.org, vadimsh+cc_chromium.org, maruel+cc_chromium.org, phajdan.jr
Base URL:
https://code.google.com/p/swarming.client@master
Visibility:
Public.

Description

Make licensecheck.pl happy by tweaking the license header. This is a redo of 8add124a2801 but with exact wording. This debian script is fairly strict in the wording is accepts to detect a file under the Apache license. Fix the wording so it'll be detected properly. Ran tests/run_isolated/regen_test_data.py to regenerate the test data. R=vadimsh@chromium.org BUG= Committed: https://code.google.com/p/swarming/source/detail?repo=client&r=e98b112

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -224 lines) Patch
M PRESUBMIT.py View 2 chunks +5 lines, -5 lines 0 comments Download
M README.py View 1 chunk +2 lines, -2 lines 0 comments Download
M WATCHLISTS View 1 chunk +2 lines, -2 lines 0 comments Download
M example/hello_world.isolate View 1 chunk +2 lines, -2 lines 0 comments Download
M example/hello_world.py View 1 chunk +2 lines, -2 lines 0 comments Download
M example/run_example_cad.py View 1 chunk +2 lines, -2 lines 0 comments Download
M example/run_example_local.py View 1 chunk +2 lines, -2 lines 0 comments Download
M example/run_example_swarm.py View 1 chunk +2 lines, -2 lines 0 comments Download
M googletest/README.py View 1 chunk +2 lines, -2 lines 0 comments Download
M googletest/fix_test_cases.py View 1 chunk +2 lines, -2 lines 0 comments Download
M googletest/isolate_test_cases.py View 1 chunk +2 lines, -2 lines 0 comments Download
M googletest/list_test_cases.py View 1 chunk +2 lines, -2 lines 0 comments Download
M googletest/run_test_cases.py View 1 chunk +2 lines, -2 lines 0 comments Download
M googletest/shard_test_cases.py View 1 chunk +2 lines, -2 lines 0 comments Download
M googletest/tests/fix_test_cases_smoke_test.py View 1 chunk +2 lines, -2 lines 0 comments Download
M googletest/tests/gtest_fake/gtest_fake_base.py View 1 chunk +2 lines, -2 lines 0 comments Download
M googletest/tests/gtest_fake/gtest_fake_confused_fail.py View 1 chunk +2 lines, -2 lines 0 comments Download
M googletest/tests/gtest_fake/gtest_fake_confused_pass.py View 1 chunk +2 lines, -2 lines 0 comments Download
M googletest/tests/gtest_fake/gtest_fake_crash_after_pass.py View 1 chunk +2 lines, -2 lines 0 comments Download
M googletest/tests/gtest_fake/gtest_fake_error.py View 1 chunk +2 lines, -2 lines 0 comments Download
M googletest/tests/gtest_fake/gtest_fake_fail.py View 1 chunk +2 lines, -2 lines 0 comments Download
M googletest/tests/gtest_fake/gtest_fake_flaky.py View 1 chunk +2 lines, -2 lines 0 comments Download
M googletest/tests/gtest_fake/gtest_fake_missing.py View 1 chunk +2 lines, -2 lines 0 comments Download
M googletest/tests/gtest_fake/gtest_fake_pass.py View 1 chunk +2 lines, -2 lines 0 comments Download
M googletest/tests/gtest_fake/gtest_fake_slow.py View 1 chunk +2 lines, -2 lines 0 comments Download
M googletest/tests/isolate_test_cases/gtest_fake_pass.isolate View 1 chunk +2 lines, -2 lines 0 comments Download
M googletest/tests/isolate_test_cases_smoke_test.py View 1 chunk +2 lines, -2 lines 0 comments Download
M googletest/tests/list_test_cases_smoke_test.py View 1 chunk +2 lines, -2 lines 0 comments Download
M googletest/tests/run_test_cases/output.py View 1 chunk +2 lines, -2 lines 0 comments Download
M googletest/tests/run_test_cases_smoke_test.py View 1 chunk +2 lines, -2 lines 0 comments Download
M googletest/tests/run_test_cases_test.py View 1 chunk +2 lines, -2 lines 0 comments Download
M googletest/tests/trace_test_cases_smoke_test.py View 1 chunk +2 lines, -2 lines 0 comments Download
M googletest/trace_test_cases.py View 1 chunk +2 lines, -2 lines 0 comments Download
M isolate.py View 1 chunk +2 lines, -2 lines 0 comments Download
M isolate_merge.py View 1 chunk +2 lines, -2 lines 0 comments Download
M isolateserver.py View 1 chunk +2 lines, -2 lines 0 comments Download
M run_isolated.py View 1 chunk +2 lines, -2 lines 0 comments Download
M swarming.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/auto_stub.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/file_path_test.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/isolate/all_items_invalid.isolate View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/isolate/empty.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/isolate/fail.isolate View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/isolate/fail.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/isolate/missing_trailing_slash.isolate View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/isolate/no_run.isolate View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/isolate/non_existent.isolate View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/isolate/simple.isolate View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/isolate/simple.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/isolate/split.isolate View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/isolate/split.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/isolate/symlink_full.isolate View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/isolate/symlink_full.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/isolate/symlink_outside_build_root.isolate View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/isolate/symlink_outside_build_root.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/isolate/symlink_partial.isolate View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/isolate/symlink_partial.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/isolate/touch_only.isolate View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/isolate/touch_only.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/isolate/touch_root.isolate View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/isolate/touch_root.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/isolate/with_flag.isolate View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/isolate/with_flag.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/isolate_smoke_test.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/isolate_test.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/isolateserver_smoke_test.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/isolateserver_test.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/lru_test.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/net_test.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/run_isolated/check_files.isolated View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/run_isolated/check_files.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/run_isolated/download.isolated View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/run_isolated/regen_test_data.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/run_isolated/repeated_files.isolated View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/run_isolated/repeated_files.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/run_isolated_smoke_test.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/short_expression_finder_test.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/swarming_smoke_test.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/swarming_test.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/threading_utils_test.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/trace_inputs/child1.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/trace_inputs/child2.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/trace_inputs/symlink.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/trace_inputs/touch_only.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/trace_inputs/tricky_filename.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/trace_inputs_smoke_test.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/trace_inputs_test.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/url_open_timeout_test.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/zip_package_test.py View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/chromium/python26_polyfill.py View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/depot_tools/fix_encoding.py View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/depot_tools/subcommand.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/harvest_buildbot.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/isolateserver_load_test.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/run_a_test.isolate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/run_swarm_tests_on_swarm.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/swarm_cleanup.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/swarming_load_test_bot.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/swarming_load_test_client.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/zip_profiler.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/zip_run_isolated.py View 1 chunk +2 lines, -2 lines 0 comments Download
M trace_inputs.py View 1 chunk +2 lines, -2 lines 0 comments Download
M utils/file_path.py View 1 chunk +2 lines, -2 lines 0 comments Download
M utils/graph.py View 1 chunk +2 lines, -2 lines 0 comments Download
M utils/lru.py View 1 chunk +2 lines, -2 lines 0 comments Download
M utils/net.py View 1 chunk +2 lines, -2 lines 0 comments Download
M utils/short_expression_finder.py View 1 chunk +2 lines, -2 lines 0 comments Download
M utils/threading_utils.py View 1 chunk +2 lines, -2 lines 0 comments Download
M utils/tools.py View 1 chunk +2 lines, -2 lines 0 comments Download
M utils/zip_package.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
M-A
manually tested it to pass with the checklicense.py script.
11 years, 8 months ago (2013-11-06 01:17:03 UTC) #1
vadimsh
lgtm
11 years, 8 months ago (2013-11-06 01:19:47 UTC) #2
M-A
11 years, 8 months ago (2013-11-06 01:28:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as re98b112 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b