Issue 219460043: Issue 3615: more consistency with key sig grobs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 219460043: Issue 3615: more consistency with key sig grobs (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years ago by pwm

Modified:
8 years, 11 months ago

Reviewers:
pkx166h, david.nalesnik

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Issue 3615: more consistency with key sig grobs Always create KeySignature grobs, even when the key has no sharps or flats, for greater consistency when overriding them. (key-engraver.cc)

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	lily/key-engraver.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

david.nalesnik

On 2015/03/29 20:33:33, pwm wrote: > Please review, thanks. Could you provide an example where ...

9 years ago (2015-03-30 16:36:20 UTC) #2

david.nalesnik

On 2015/03/30 16:36:20, david.nalesnik wrote: > On 2015/03/29 20:33:33, pwm wrote: > > Please review, ...

9 years ago (2015-03-30 16:38:12 UTC) #3

pkx166h

9 years ago (2015-04-12 22:45:00 UTC) #4

author	Paul Morris <paulwmorris@gmail.com>	
	Sun, 29 Mar 2015 18:09:52 +0000 (14:09 -0400)
committer	James Lowe <pkx166h@gmail.com>	
	Sun, 12 Apr 2015 22:42:44 +0000 (23:42 +0100)
commit	cbe0ea8e6413ddf779de852755ce811b5a8319fe

Expand All Messages | Collapse All Messages