Issue 219390043: TBR: i#1551 ARM, i#1613 annotations: disable annotations for ARM

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 219390043: TBR: i#1551 ARM, i#1613 annotations: disable annotations for ARM

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years ago by bruening

Modified:
9 years ago

Reviewers:
zhaoqin

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- i#1551 ARM, i#1613 annotations: disable annotations for ARM The enabling of the ANNOTATIONS option breaks the ARM build so we set it back to default-off for ARM and default-on for x86. ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	CMakeLists.txt	View		1 chunk	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bruening

9 years ago (2015-03-26 20:54:51 UTC) #2

Committed as
https://github.com/DynamoRIO/dynamorio/commit/121c951a50ebaa51690b91fa74ef8da...

Final commit log: 
---------------
i#1551 ARM, i#1613 annotations: disable annotations for ARM

The enabling of the ANNOTATIONS option breaks the ARM build so we set it
back to default-off for ARM and default-on for x86.

Review-URL: https://codereview.appspot.com/219390043
---------------

Expand All Messages | Collapse All Messages