Issue 218900044: TBR: i#1551 port to ARM: predicate app instrs added in mangling

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 218900044: TBR: i#1551 port to ARM: predicate app instrs added in mangling

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years ago by bruening

Modified:
9 years ago

Reviewers:
zhaoqin

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- i#1551 port to ARM: predicate app instrs added in mangling Fixes a bug mangling stmiane where the app instr would crash but it's predicated and does not execute, yet our mangling fixup is not predicated and crashes. We need to mark the fixup store as predicated and as an app (non-meta) instr. Adds a test to allasm_thumb. ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -4 lines)			Patch
	M	core/arch/arm/mangle.c	View		2 chunks	+10 lines, -4 lines	0 comments	Download
	M	suite/tests/common/allasm_thumb.asm	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bruening

9 years ago (2015-03-26 20:54:31 UTC) #2

Committed as
https://github.com/DynamoRIO/dynamorio/commit/6dac5f56bed11609a63824dff3e54ac...

Final commit log: 
---------------
i#1551 port to ARM: predicate app instrs added in mangling

Fixes a bug mangling stmiane where the app instr would crash but it's
predicated and does not execute, yet our mangling fixup is not predicated
and crashes.  We need to mark the fixup store as predicated and as an app
(non-meta) instr.

Adds a test to allasm_thumb.

Review-URL: https://codereview.appspot.com/218900044
---------------

Expand All Messages | Collapse All Messages