Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(706)

Issue 218290043: Added AndroidSurfaceFlinger, auditor renamings (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years ago by Chris Craik
Modified:
9 years ago
Reviewers:
nduca
CC:
trace-viewer-review_googlegroups.com
Base URL:
https://github.com/google/trace-viewer.git@master
Visibility:
Public.

Description

Added AndroidSurfaceFlinger, auditor renamings R=nduca@chromium.org Committed: https://chromium.googlesource.com/external/trace-viewer/+/5f89a0f2d1e65f8f243c614763360354f8b63554

Patch Set 1 #

Total comments: 1

Patch Set 2 : added vsync querying #

Unified diffs Side-by-side diffs Delta from patch set Stats (+217 lines, -31 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M trace_viewer.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M trace_viewer/core/test_utils.html View 2 chunks +6 lines, -0 lines 0 comments Download
M trace_viewer/extras/audits/android_app.html View 2 chunks +1 line, -3 lines 0 comments Download
M trace_viewer/extras/audits/android_auditor.html View 2 chunks +28 lines, -6 lines 0 comments Download
M trace_viewer/extras/audits/android_auditor_test.html View 2 chunks +39 lines, -0 lines 0 comments Download
M trace_viewer/extras/audits/android_model_helper.html View 6 chunks +8 lines, -21 lines 0 comments Download
M trace_viewer/extras/audits/android_model_helper_test.html View 1 2 chunks +28 lines, -1 line 0 comments Download
A trace_viewer/extras/audits/android_surface_flinger.html View 1 1 chunk +105 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Chris Craik
9 years ago (2015-03-27 02:58:35 UTC) #1
nduca
lgtm https://codereview.appspot.com/218290043/diff/1/trace_viewer/extras/audits/android_surface_flinger.html File trace_viewer/extras/audits/android_surface_flinger.html (right): https://codereview.appspot.com/218290043/diff/1/trace_viewer/extras/audits/android_surface_flinger.html#newcode40 trace_viewer/extras/audits/android_surface_flinger.html:40: this.appVsync_ = undefined; would be good if the ...
9 years ago (2015-03-27 17:50:38 UTC) #2
Chris Craik
9 years ago (2015-03-27 17:55:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
5f89a0f2d1e65f8f243c614763360354f8b63554 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b