Issue 217370044: i#1551 Port DynamoRIO to ARM: add IT block handling for mangle_reads_thread_register

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 217370044: i#1551 Port DynamoRIO to ARM: add IT block handling for mangle_reads_thread_register

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years ago by zhaoqin

Modified:
9 years ago

Reviewers:
bruening

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- i#1551 Port DynamoRIO to ARM: add IT block handling for mangle_reads_thread_register - add IT block handling for mangle_reads_thread_register - add helper function app_instr_is_in_it_block ---------------

Patch Set 1 #

Total comments: 2

Patch Set 2 : PTAL #

Patch Set 3 : Committed #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -19 lines)			Patch
M	core/arch/arch.h	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	core/arch/arm/mangle.c	View	1	8 chunks	+31 lines, -16 lines	0 comments	Download
M	core/arch/mangle_shared.c	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bruening

Looks like there is a bug https://codereview.appspot.com/217370044/diff/1/core/arch/arm/mangle.c File core/arch/arm/mangle.c (right): https://codereview.appspot.com/217370044/diff/1/core/arch/arm/mangle.c#newcode717 core/arch/arm/mangle.c:717: return true; nit: ...

9 years ago (2015-03-26 21:31:54 UTC) #2

zhaoqin

Commit log for latest patchset: --------------- i#1551 Port DynamoRIO to ARM: add IT block handling ...

9 years ago (2015-03-26 21:48:01 UTC) #3

zhaoqin

9 years ago (2015-03-27 15:20:37 UTC) #5

Committed as
https://github.com/DynamoRIO/dynamorio/commit/e5a8904a8c04a7551cae32b7faef294...

Final commit log: 
---------------
i#1551 Port DynamoRIO to ARM: add IT block handling for
mangle_reads_thread_register

- add IT block handling for mangle_reads_thread_register
- add helper function app_instr_is_in_it_block

Review-URL: https://codereview.appspot.com/217370044
---------------

Expand All Messages | Collapse All Messages