Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1691)

Issue 217370043: Update this test to take a dump of a child process. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years ago by Erik Wright
Modified:
9 years ago
CC:
syzygy-changes_googlegroups.com, Siggi, Robert, chrisha
Base URL:
https://code.google.com/p/syzygy.git@master
Visibility:
Public.

Description

Update this test to take a dump of a child process. Other tests taking dumps of the main test process have been observed to hang. Although this test doesn't seem to have, it seems prudent to pre-emptively fix it. BUG= R=sebmarchand@chromium.org Committed: https://code.google.com/p/syzygy/source/detail?r=e1f61ff378a94cd083683c174a9c6e9612e9f2d1

Patch Set 1 #

Patch Set 2 : Create -> OpenEvent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -21 lines) Patch
M syzygy/kasko/minidump_unittest.cc View 1 7 chunks +85 lines, -21 lines 0 comments Download

Messages

Total messages: 3
Erik Wright
seb: PTAL.
9 years ago (2015-03-26 20:27:39 UTC) #1
Sébastien Marchand
lgtm
9 years ago (2015-03-27 01:26:01 UTC) #2
Erik Wright
9 years ago (2015-03-27 14:44:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e1f61ff378a94cd083683c174a9c6e9612e9f2d1.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b