Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(222)

Issue 217200043: DateSplitTransform example (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years ago by elarson
Modified:
8 years, 11 months ago
Reviewers:
pjo, Tanmay Vartak
Visibility:
Public.

Description

DateSplitTransform example

Patch Set 1 #

Total comments: 6

Patch Set 2 : Removed multi-value date transform, modified logging #

Total comments: 4

Patch Set 3 : modified logging #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -0 lines) Patch
A src/com/google/enterprise/adaptor/examples/DateSplitTransform.java View 1 2 1 chunk +96 lines, -0 lines 0 comments Download

Messages

Total messages: 13
elarson
9 years ago (2015-03-23 21:31:19 UTC) #1
Tanmay Vartak
I am not sure what are exact requirements here but I assume this is originated ...
9 years ago (2015-03-23 22:23:43 UTC) #2
elarson
https://codereview.appspot.com/217200043/diff/1/src/com/google/enterprise/adaptor/examples/DateSplitTransform.java File src/com/google/enterprise/adaptor/examples/DateSplitTransform.java (right): https://codereview.appspot.com/217200043/diff/1/src/com/google/enterprise/adaptor/examples/DateSplitTransform.java#newcode84 src/com/google/enterprise/adaptor/examples/DateSplitTransform.java:84: Integer.toString(cal.get(Calendar.YEAR))); Yes, this came from a customer request for ...
9 years ago (2015-03-24 18:00:19 UTC) #3
pjo
2 comments. LGTM. Please wait for Tanmay to also LGTM. Thank you very much! https://codereview.appspot.com/217200043/diff/1/src/com/google/enterprise/adaptor/examples/DateSplitTransform.java ...
9 years ago (2015-03-24 18:16:34 UTC) #4
elarson
Removed multi-value date transform, modified logging
9 years ago (2015-03-25 22:33:20 UTC) #5
elarson
Changes made - I removed the multi-value logic since I don't think it makes sense ...
9 years ago (2015-03-25 22:36:44 UTC) #6
pjo
Still LGTM. Please wait for Tanmay to also give LGTM. Thank you, PJ https://codereview.appspot.com/217200043/diff/20001/src/com/google/enterprise/adaptor/examples/DateSplitTransform.java File ...
9 years ago (2015-03-25 22:43:31 UTC) #7
Tanmay Vartak
On 2015/03/25 22:43:31, pjo wrote: > Still LGTM. Please wait for Tanmay to also give ...
9 years ago (2015-03-26 16:24:44 UTC) #8
Tanmay Vartak
I missed my comments earlier but still LGTM https://codereview.appspot.com/217200043/diff/20001/src/com/google/enterprise/adaptor/examples/DateSplitTransform.java File src/com/google/enterprise/adaptor/examples/DateSplitTransform.java (right): https://codereview.appspot.com/217200043/diff/20001/src/com/google/enterprise/adaptor/examples/DateSplitTransform.java#newcode90 src/com/google/enterprise/adaptor/examples/DateSplitTransform.java:90: log.log(Level.FINEST, ...
9 years ago (2015-03-26 16:34:24 UTC) #9
elarson
modified logging
9 years ago (2015-03-26 20:33:47 UTC) #10
elarson
OK, uploaded the latest revisions. Not sure there's a good one-size-fits-all solution for multivalue, so ...
9 years ago (2015-03-26 20:35:29 UTC) #11
pjo
Thank you. You have the LGTMs. Push it to github. Cheers
9 years ago (2015-03-26 20:40:56 UTC) #12
pjo
8 years, 11 months ago (2015-05-05 00:41:56 UTC) #13
please close at https://codereview.appspot.com/

thank you
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b