Issue 217107: Python parsedate two-digit year behavior (Py3k)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 217107: Python parsedate two-digit year behavior (Py3k)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 2 months ago by jfinkels

Modified:
13 years, 8 months ago

Reviewers:
merwok

Visibility:
Public.

Patch Set 1 #

Total comments: 2

Created: 14 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -21 lines)			Patch
	M	Lib/email/_parseaddr.py	View		7 chunks	+39 lines, -19 lines	2 comments	Download
	M	Lib/email/test/test_email.py	View		1 chunk	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

merwok

13 years, 8 months ago (2010-08-21 15:24:14 UTC) #1

I don’t know much about email, but the code itself looks good to me. I see there
is only one new test; I hope this means that the old behavior is already covered
and that the new code does not break compatibility. If this is the case, nice
bug fix.

http://codereview.appspot.com/217107/diff/1/2
File Lib/email/_parseaddr.py (right):

http://codereview.appspot.com/217107/diff/1/2#newcode1
Lib/email/_parseaddr.py:1: # Copyright (C) 2002-2007, 2010 Python Software
Foundation
“2002-2010” would make more sense.

http://codereview.appspot.com/217107/diff/1/2#newcode24
Lib/email/_parseaddr.py:24: DOY_UNKNOWN = 1
Can you add a comment explaining what DOY means, unless it’s obvious for email
specialists?

Expand All Messages | Collapse All Messages