Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(166)

Issue 217107: Python parsedate two-digit year behavior (Py3k)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by jfinkels
Modified:
11 years ago
Reviewers:
merwok
Visibility:
Public.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -21 lines) Patch
M Lib/email/_parseaddr.py View 7 chunks +39 lines, -19 lines 2 comments Download
M Lib/email/test/test_email.py View 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 1
merwok
11 years ago (2010-08-21 15:24:14 UTC) #1
I don’t know much about email, but the code itself looks good to me. I see there
is only one new test; I hope this means that the old behavior is already covered
and that the new code does not break compatibility. If this is the case, nice
bug fix.

http://codereview.appspot.com/217107/diff/1/2
File Lib/email/_parseaddr.py (right):

http://codereview.appspot.com/217107/diff/1/2#newcode1
Lib/email/_parseaddr.py:1: # Copyright (C) 2002-2007, 2010 Python Software
Foundation
“2002-2010” would make more sense.

http://codereview.appspot.com/217107/diff/1/2#newcode24
Lib/email/_parseaddr.py:24: DOY_UNKNOWN = 1
Can you add a comment explaining what DOY means, unless it’s obvious for email
specialists?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b