Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(796)

Issue 211520043: "issue #463 correct history view of tickets"

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years ago by pjoshi
Modified:
9 years ago
Reviewers:
thomas.j.waldmann
Visibility:
Public.

Description

"issue #463 correct history view of tickets"

Patch Set 1 #

Total comments: 15

Patch Set 2 : "Correct old errors for the same issue" #

Total comments: 1

Patch Set 3 : "Correct view for both normal tickets and tickets in history" #

Patch Set 4 : "correcting view by removing top navbar from the history ticket view" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -41 lines) Patch
M MoinMoin/items/ticket.py View 1 2 chunks +15 lines, -2 lines 0 comments Download
M MoinMoin/templates/forms.html View 1 chunk +6 lines, -0 lines 0 comments Download
M MoinMoin/templates/ticket/base.html View 1 2 3 1 chunk +0 lines, -39 lines 0 comments Download
M MoinMoin/templates/ticket/modify.html View 1 2 3 1 chunk +39 lines, -0 lines 0 comments Download
A MoinMoin/templates/ticket/show.html View 1 2 1 chunk +57 lines, -0 lines 0 comments Download
M MoinMoin/templates/ticket/submit.html View 1 2 3 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Thomas.J.Waldmann
https://codereview.appspot.com/211520043/diff/1/MoinMoin/apps/frontend/views.py File MoinMoin/apps/frontend/views.py (left): https://codereview.appspot.com/211520043/diff/1/MoinMoin/apps/frontend/views.py#oldcode456 MoinMoin/apps/frontend/views.py:456: this looks like an accidental and not pep8-compliant change ...
9 years ago (2015-03-10 19:19:13 UTC) #1
pjoshi
Answer to queries https://codereview.appspot.com/211520043/diff/1/MoinMoin/apps/frontend/views.py File MoinMoin/apps/frontend/views.py (left): https://codereview.appspot.com/211520043/diff/1/MoinMoin/apps/frontend/views.py#oldcode456 MoinMoin/apps/frontend/views.py:456: On 2015/03/10 19:19:12, Thomas.J.Waldmann wrote: > ...
9 years ago (2015-03-10 19:44:50 UTC) #2
pjoshi
9 years ago (2015-03-10 21:44:46 UTC) #3
https://codereview.appspot.com/211520043/diff/20001/MoinMoin/templates/ticket...
File MoinMoin/templates/ticket/show.html (right):

https://codereview.appspot.com/211520043/diff/20001/MoinMoin/templates/ticket...
MoinMoin/templates/ticket/show.html:21: {% block footer_itemviews %}
added this because we don't need a navbar which contains links for editing the
tickets like subscription etc.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b