Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(985)

Issue 207090043: i#1607 client.alloc: probe for free page on hint tests

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 1 month ago by Byron
Modified:
9 years, 1 month ago
Reviewers:
bruening
CC:
dynamorio-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- i#1607 client.alloc: probe for free page on hint tests The client.alloc test was using a hardcoded value as a hint to dr_raw_mem_alloc() and dr_custom_alloc(), which causes the test to fail when that address happens to be occupied. This commit adds a probe phase to these tests, which first finds a free page of memory and then uses that address as the hint. Fixes #1607 ---------------

Patch Set 1 #

Total comments: 9

Patch Set 2 : Added comment about 64k alignment on Windows. Removed unused constant from 32-bit build. #

Patch Set 3 : Committed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -9 lines) Patch
M suite/tests/client-interface/alloc.dll.c View 1 6 chunks +45 lines, -9 lines 0 comments Download

Messages

Total messages: 7
Byron
9 years, 1 month ago (2015-02-27 10:50:27 UTC) #1
Byron
https://codereview.appspot.com/207090043/diff/1/suite/tests/client-interface/alloc.dll.c File suite/tests/client-interface/alloc.dll.c (left): https://codereview.appspot.com/207090043/diff/1/suite/tests/client-interface/alloc.dll.c#oldcode108 suite/tests/client-interface/alloc.dll.c:108: byte *highmem = PREFERRED_ADDR; Do we want to omit ...
9 years, 1 month ago (2015-02-27 10:55:24 UTC) #2
bruening
LGTM w/ comment https://codereview.appspot.com/207090043/diff/1/suite/tests/client-interface/alloc.dll.c File suite/tests/client-interface/alloc.dll.c (left): https://codereview.appspot.com/207090043/diff/1/suite/tests/client-interface/alloc.dll.c#oldcode108 suite/tests/client-interface/alloc.dll.c:108: byte *highmem = PREFERRED_ADDR; On 2015/02/27 ...
9 years, 1 month ago (2015-02-27 16:06:54 UTC) #3
Byron
Commit log for latest patchset: --------------- i#1607 client.alloc: probe for free page on hint tests ...
9 years, 1 month ago (2015-02-27 18:48:52 UTC) #4
Byron
Suggesting alternatives to preserve testing of high addresses on 64-bit. https://codereview.appspot.com/207090043/diff/1/suite/tests/client-interface/alloc.dll.c File suite/tests/client-interface/alloc.dll.c (left): https://codereview.appspot.com/207090043/diff/1/suite/tests/client-interface/alloc.dll.c#oldcode245 ...
9 years, 1 month ago (2015-02-27 18:50:20 UTC) #5
bruening
https://codereview.appspot.com/207090043/diff/1/suite/tests/client-interface/alloc.dll.c File suite/tests/client-interface/alloc.dll.c (left): https://codereview.appspot.com/207090043/diff/1/suite/tests/client-interface/alloc.dll.c#oldcode245 suite/tests/client-interface/alloc.dll.c:245: char *array = PREFERRED_ADDR; On 2015/02/27 18:50:20, Byron wrote: ...
9 years, 1 month ago (2015-02-27 18:52:53 UTC) #6
Byron
9 years, 1 month ago (2015-02-27 18:55:26 UTC) #7
Committed as
https://github.com/DynamoRIO/dynamorio/commit/8659ae66dc6062cedef87e7f2b62219...

Final commit log: 
---------------
i#1607 client.alloc: probe for free page on hint tests

The client.alloc test was using a hardcoded value as a hint
to dr_raw_mem_alloc() and dr_custom_alloc(), which causes the
test to fail when that address happens to be occupied. This
commit adds a probe phase to these tests, which first finds a
free page of memory and then uses that address as the hint.

Fixes #1607

Review-URL: https://codereview.appspot.com/207090043
---------------
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b