Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(29)

Issue 206770044: Doc: issue 1432 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 9 months ago by barrykp
Modified:
2 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Doc: issue 1432 Replaced tabs with spaces in .ly files in /ly

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+847 lines, -854 lines) Patch
M ly/arabic.ly View 1 chunk +13 lines, -13 lines 0 comments Download
M ly/articulate.ly View 19 chunks +341 lines, -341 lines 0 comments Download
M ly/chord-modifiers-init.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M ly/chord-repetition-init.ly View 1 chunk +1 line, -1 line 0 comments Download
M ly/drumpitch-init.ly View 2 chunks +79 lines, -81 lines 1 comment Download
M ly/dynamic-scripts-init.ly View 1 chunk +0 lines, -1 line 0 comments Download
M ly/engraver-init.ly View 2 chunks +5 lines, -5 lines 0 comments Download
M ly/event-listener.ly View 1 chunk +13 lines, -13 lines 0 comments Download
M ly/graphviz-init.ly View 3 chunks +4 lines, -4 lines 0 comments Download
M ly/gregorian.ly View 6 chunks +75 lines, -75 lines 0 comments Download
M ly/init.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M ly/makam.ly View 8 chunks +11 lines, -12 lines 0 comments Download
M ly/midi-init.ly View 1 chunk +0 lines, -1 line 0 comments Download
M ly/music-functions-init.ly View 35 chunks +191 lines, -191 lines 0 comments Download
M ly/predefined-guitar-ninth-fretboards.ly View 1 chunk +17 lines, -17 lines 0 comments Download
M ly/property-init.ly View 4 chunks +9 lines, -9 lines 1 comment Download
M ly/satb.ly View 8 chunks +25 lines, -26 lines 0 comments Download
M ly/scale-definitions-init.ly View 6 chunks +5 lines, -6 lines 0 comments Download
M ly/script-init.ly View 3 chunks +14 lines, -14 lines 0 comments Download
M ly/spanners-init.ly View 3 chunks +9 lines, -9 lines 0 comments Download
M ly/string-tunings-init.ly View 1 chunk +1 line, -1 line 0 comments Download
M ly/text-replacements.ly View 1 chunk +3 lines, -3 lines 0 comments Download
M ly/toc-init.ly View 2 chunks +27 lines, -27 lines 0 comments Download

Messages

Total messages: 13
barrykp
Replaced tabs with (8) spaces in all of the .ly files in /ly. Please review! ...
3 years, 9 months ago (2015-02-19 16:36:22 UTC) #1
dak
https://codereview.appspot.com/206770044/diff/1/ly/drumpitch-init.ly File ly/drumpitch-init.ly (right): https://codereview.appspot.com/206770044/diff/1/ly/drumpitch-init.ly#newcode154 ly/drumpitch-init.ly:154: midiDrumPitches = This is not just replacing tabs with ...
3 years, 9 months ago (2015-02-19 16:46:57 UTC) #2
fedelogy
I would remove trailing spaces also
3 years, 9 months ago (2015-02-19 16:47:38 UTC) #3
barrykp
On Thu, Feb 19, 2015 at 4:46 PM, <dak@gnu.org> wrote: > This is not just ...
3 years, 9 months ago (2015-02-19 17:09:16 UTC) #4
c_sorensen
Perhaps the issue name should be changed to "Fix whitespace in *-init.ly" Then you could ...
3 years, 9 months ago (2015-02-21 13:22:26 UTC) #5
pkx166h
This issue also says it is blocked by https://code.google.com/p/lilypond/issues/detail?id=777 But I am not sure if ...
3 years, 9 months ago (2015-02-21 17:45:57 UTC) #6
barrykp
On Sat, Feb 21, 2015 at 5:45 PM, <pkx166h@gmail.com> wrote: > This issue also says ...
3 years, 9 months ago (2015-02-21 18:30:06 UTC) #7
pkx166h
Barry, I think this still has a little more work that needs to be done ...
3 years, 9 months ago (2015-02-25 17:04:26 UTC) #8
c_sorensen
On 2/25/15 10:04 AM, "pkx166h@gmail.com" <pkx166h@gmail.com> wrote: >Barry, I think this still has a little ...
3 years, 9 months ago (2015-02-25 17:17:13 UTC) #9
pkx166h
On 2015/02/25 17:17:13, c_sorensen wrote: > > On 2/25/15 10:04 AM, mailto:"pkx166h@gmail.com" <mailto:pkx166h@gmail.com> wrote: > ...
3 years, 9 months ago (2015-02-25 18:14:39 UTC) #10
pkx166h
Patch counted down - please push. Barry if you make a git formatted patch, I ...
3 years, 9 months ago (2015-02-28 11:17:38 UTC) #11
barrykp
On Sat, Feb 28, 2015 at 11:17 AM, <pkx166h@gmail.com> wrote: > Barry if you make ...
3 years, 9 months ago (2015-02-28 17:31:18 UTC) #12
pkx166h
3 years, 9 months ago (2015-03-01 11:02:29 UTC) #13
Thanks Barry.

This has been pushed.

author	Kevin Barry <barrykp@gmail.com>	
	Thu, 19 Feb 2015 15:51:52 +0000 (15:51 +0000)
committer	James Lowe <pkx166h@gmail.com>	
	Sun, 1 Mar 2015 10:53:10 +0000 (10:53 +0000)
commit	67ed495d4f5e6a02224f87faf4c00979996675e0

You can close this Rietveld issue now.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b