cmd/juju: use API for resolved

cmd/juju: use API for resolved

Partially fixes #1246983

https://code.launchpad.net/~axwalk/juju-core/lp1246983-cli-api-resolved/+merge/193564

(do not edit description out of merge proposal)

[axw, 2013-11-01 09:30:31]

Please take a look.

[john2, 2013-11-02 20:30:56]

This code is nice and straightforward, but because I was digging around with the
other test changes, I noticed that the tests of the API don't actually exercise
the Retry logic.

I'm not going to block landing this on writing those tests, because you aren't
*reducing* test coverage at all. But could you try to add some coverage while
we're away from it?

If the test is too fiddly or time consuming, file a tech-debt bug, link to it in
the source code and you can land this.

[axw, 2013-11-04 02:43:28]

On 2013/11/02 20:30:56, john2 wrote:
> This code is nice and straightforward, but because I was digging around with
the
> other test changes, I noticed that the tests of the API don't actually
exercise
> the Retry logic.
> 
> I'm not going to block landing this on writing those tests, because you aren't
> *reducing* test coverage at all. But could you try to add some coverage while
> we're away from it?
> 
> If the test is too fiddly or time consuming, file a tech-debt bug, link to it
in
> the source code and you can land this.

I've expanded TestClientUnitResolved to ensure that if retry is true, the
correct resolved mode is set.

[axw, 2013-11-04 02:52:33]

Please take a look.

[jameinel, 2013-11-05 04:43:12]

LGTM

https://codereview.appspot.com/20670044/diff/20001/state/apiserver/client/cli...
File state/apiserver/client/client_test.go (right):

https://codereview.appspot.com/20670044/diff/20001/state/apiserver/client/cli...
state/apiserver/client/client_test.go:375: }}
I would actually say that this is a case where having 2 tests is clearer about
what is going on. Possibly a helper function that takes the parameters if there
is too much repeated code.

But meh, good enough.

[axw, 2013-11-05 04:58:24]

https://codereview.appspot.com/20670044/diff/20001/state/apiserver/client/cli...
File state/apiserver/client/client_test.go (right):

https://codereview.appspot.com/20670044/diff/20001/state/apiserver/client/cli...
state/apiserver/client/client_test.go:375: }}
On 2013/11/05 04:43:13, jameinel wrote:
> I would actually say that this is a case where having 2 tests is clearer about
> what is going on. Possibly a helper function that takes the parameters if
there
> is too much repeated code.

Agreed; changing to two tests.

> But meh, good enough.