Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(100)

Issue 2065041: Fix 1240. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 8 months ago by joeneeman
Modified:
2 years, 10 months ago
Reviewers:
carl.d.sorensen
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fix 1240.

Include fixed spacings in the calculation of minimum spacings.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -6 lines) Patch
M lily/align-interface.cc View 7 chunks +19 lines, -3 lines 0 comments Download
M lily/grob.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M lily/include/align-interface.hh View 1 chunk +2 lines, -1 line 0 comments Download
M lily/include/grob.hh View 1 chunk +1 line, -0 lines 0 comments Download
M lily/include/page-layout-problem.hh View 1 chunk +1 line, -0 lines 0 comments Download
M lily/include/system.hh View 1 chunk +2 lines, -0 lines 0 comments Download
M lily/page-layout-problem.cc View 2 chunks +34 lines, -1 line 0 comments Download
M lily/system.cc View 2 chunks +24 lines, -1 line 0 comments Download

Messages

Total messages: 2
Carl
I barely feel qualified to review this, but it looks fine to me. I could ...
3 years, 7 months ago #1
joeneeman
3 years, 6 months ago #2
Thanks. In the end, I committed this mostly as-is, but a change I made while
working on 1252 allowed me to do without the dummy Paper_columns.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5