Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(708)

Issue 205080043: fixes #469 removed toggle text from /+orphans, used title attribute

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 1 month ago by vipul
Modified:
8 years, 9 months ago
Reviewers:
Visibility:
Public.

Description

fixes #469 removed toggle text from /+orphans, used title attribute

Patch Set 1 #

Patch Set 2 : fixes #469 removed toggle text from /+orphans, used title attribute #

Total comments: 2

Patch Set 3 : fixes #469 removed toggle text from /+orphans, used title attribute #

Total comments: 2

Patch Set 4 : fixes #469 removed toggle text from /+orphans, used title attribute #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -25 lines) Patch
M MoinMoin/static/js/common.js View 1 chunk +0 lines, -16 lines 0 comments Download
M MoinMoin/templates/link_list_item_panel.html View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M MoinMoin/templates/link_list_no_item_panel.html View 1 2 3 2 chunks +2 lines, -7 lines 0 comments Download
M MoinMoin/templates/sitemap.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M MoinMoin/templates/utils.html View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 8
RogerHaase
What you have done looks OK, but you missed a data-fqname in templates/sitemap.html.
9 years, 1 month ago (2015-02-19 21:28:27 UTC) #1
RogerHaase
https://codereview.appspot.com/205080043/diff/20001/MoinMoin/templates/sitemap.html File MoinMoin/templates/sitemap.html (right): https://codereview.appspot.com/205080043/diff/20001/MoinMoin/templates/sitemap.html#newcode27 MoinMoin/templates/sitemap.html:27: {% endif %}> I was thinking that the data-fqname ...
9 years, 1 month ago (2015-02-21 15:59:25 UTC) #2
Thomas.J.Waldmann
you have now the same (AFAICS) code duplicated at 3 places. I suspect these are ...
9 years, 1 month ago (2015-02-21 23:04:14 UTC) #3
Thomas.J.Waldmann
https://codereview.appspot.com/205080043/diff/20001/MoinMoin/templates/link_list_no_item_panel.html File MoinMoin/templates/link_list_no_item_panel.html (right): https://codereview.appspot.com/205080043/diff/20001/MoinMoin/templates/link_list_no_item_panel.html#newcode16 MoinMoin/templates/link_list_no_item_panel.html:16: {{ fq_name.value }} indentation still buggy.
9 years, 1 month ago (2015-02-24 22:08:36 UTC) #4
Thomas.J.Waldmann
23:10 ThomasWaldmann$ RogerHaase: so you think these 3 are all? 23:13 RogerHaase$ yes, and the ...
9 years, 1 month ago (2015-02-24 22:26:34 UTC) #5
RogerHaase
https://codereview.appspot.com/205080043/diff/40001/MoinMoin/templates/link_list_item_panel.html File MoinMoin/templates/link_list_item_panel.html (right): https://codereview.appspot.com/205080043/diff/40001/MoinMoin/templates/link_list_item_panel.html#newcode16 MoinMoin/templates/link_list_item_panel.html:16: </li> per the discussion, this entire <li> structure should ...
9 years, 1 month ago (2015-02-26 20:03:19 UTC) #6
RogerHaase
looks OK to me
9 years, 1 month ago (2015-02-27 14:17:08 UTC) #7
RogerHaase
8 years, 9 months ago (2015-06-21 14:10:48 UTC) #8

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b