Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(386)

Issue 2025041: code review 2025041: build: update, streamline documentation for new $GOBIN (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by rsc
Modified:
1 year ago
Reviewers:
ambernopalduvall, r, adg, 幹你娘
Visibility:
Public.

Description

build: update, streamline documentation for new $GOBIN

Patch Set 1 #

Patch Set 2 : code review 2025041: build: update, streamline documentation for new $GOBIN #

Total comments: 5

Patch Set 3 : code review 2025041: build: update, streamline documentation for new $GOBIN #

Total comments: 2

Patch Set 4 : code review 2025041: build: update, streamline documentation for new $GOBIN #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -204 lines) Patch
M README View 1 chunk +12 lines, -27 lines 0 comments Download
M doc/install.html View 1 2 8 chunks +167 lines, -177 lines 0 comments Download

Messages

Total messages: 9
rsc
Hello adg, r (cc: golang-dev@googlegroups.com), I'd like you to review this change.
11 years, 3 months ago (2010-08-24 17:35:16 UTC) #1
r
http://codereview.appspot.com/2025041/diff/2001/3002 File doc/install.html (right): http://codereview.appspot.com/2025041/diff/2001/3002#newcode47 doc/install.html:47: Only supports Linux binaries. mention floating point? does it ...
11 years, 3 months ago (2010-08-24 21:29:59 UTC) #2
rsc
> http://codereview.appspot.com/2025041/diff/2001/3002#newcode47 > doc/install.html:47: Only supports Linux binaries. > mention floating point? > does it ...
11 years, 3 months ago (2010-08-24 22:28:44 UTC) #3
r
LGTM http://codereview.appspot.com/2025041/diff/8001/9002 File doc/install.html (right): http://codereview.appspot.com/2025041/diff/8001/9002#newcode47 doc/install.html:47: optimizer is not enabled. s/optimizer/registerizer/ or register allocator? ...
11 years, 3 months ago (2010-08-24 22:42:17 UTC) #4
adg
LGTM Hooray for less steps. On 25 August 2010 03:35, <rsc@golang.org> wrote: > Reviewers: adg, ...
11 years, 3 months ago (2010-08-24 23:13:35 UTC) #5
rsc
> http://codereview.appspot.com/2025041/diff/8001/9002#newcode47 > doc/install.html:47: optimizer is not enabled. > s/optimizer/registerizer/ or register allocator? It does ...
11 years, 3 months ago (2010-08-24 23:59:29 UTC) #6
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=0e57b750c3ec *** build: update, streamline documentation for new $GOBIN R=adg, r CC=golang-dev ...
11 years, 3 months ago (2010-08-25 00:00:53 UTC) #7
ambernopalduvall_gmail.com
1 year ago (2020-11-18 19:36:13 UTC) #8
幹你娘
1 year ago (2020-11-21 03:25:42 UTC) #9
Message was sent while issue was closed.
幹你娘
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b