code review 2025041: build: update, streamline documentation for new $GOBIN

build: update, streamline documentation for new $GOBIN

[rsc, 2010-08-24 17:35:16]

Hello adg, r (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[r, 2010-08-24 21:29:59]

http://codereview.appspot.com/2025041/diff/2001/3002
File doc/install.html (right):

http://codereview.appspot.com/2025041/diff/2001/3002#newcode47
doc/install.html:47: Only supports Linux binaries.
mention floating point?
does it still have outstanding bugs?

http://codereview.appspot.com/2025041/diff/2001/3002#newcode60
doc/install.html:60: and OS X (aka Darwin) operating systems.
s/aka/a.k.a./  to be consistent with above

http://codereview.appspot.com/2025041/diff/2001/3002#newcode61
doc/install.html:61: The full set of supported combinations is listed in the
discussion of
want to mention windows via a link? either here or up with the callout to gccgo

http://codereview.appspot.com/2025041/diff/2001/3002#newcode89
doc/install.html:89: <p>Make sure the <code>go</code> directory does not exist
or is empty.
before this, you probably want to say where to put it and maybe mention GOROOT.
you're installing in GOROOT

http://codereview.appspot.com/2025041/diff/2001/3002#newcode118
doc/install.html:118: Add /home/you/go/bin to your $PATH.
maybe it should print
You should now add ... 
to make it clearer it's up to the user.  as it is, it reads like a status report

[rsc, 2010-08-24 22:28:44]

> http://codereview.appspot.com/2025041/diff/2001/3002#newcode47
> doc/install.html:47: Only supports Linux binaries.
> mention floating point?
> does it still have outstanding bugs?

PTAL

> http://codereview.appspot.com/2025041/diff/2001/3002#newcode60
> doc/install.html:60: and OS X (aka Darwin) operating systems.
> s/aka/a.k.a./  to be consistent with above
>
> http://codereview.appspot.com/2025041/diff/2001/3002#newcode61
> doc/install.html:61: The full set of supported combinations is listed in
> the discussion of
> want to mention windows via a link? either here or up with the callout
> to gccgo

Mentioned Windows as in progress but incomplete.

> http://codereview.appspot.com/2025041/diff/2001/3002#newcode89
> doc/install.html:89: <p>Make sure the <code>go</code> directory does not
> exist or is empty.
> before this, you probably want to say where to put it and maybe mention
> GOROOT. you're installing in GOROOT

I am avoiding mention of $GOROOT until the end.
Most users don't seem to want to know.

> http://codereview.appspot.com/2025041/diff/2001/3002#newcode118
> doc/install.html:118: Add /home/you/go/bin to your $PATH.
> maybe it should print
> You should now add ...
> to make it clearer it's up to the user.  as it is, it reads like a
> status report

Changed to

*** You need to add /home/yuo/go/bin to your $PATH. ***

Russ

[r, 2010-08-24 22:42:17]

LGTM

http://codereview.appspot.com/2025041/diff/8001/9002
File doc/install.html (right):

http://codereview.appspot.com/2025041/diff/8001/9002#newcode47
doc/install.html:47: optimizer is not enabled.
s/optimizer/registerizer/ or register allocator?

http://codereview.appspot.com/2025041/diff/8001/9002#newcode122
doc/install.html:122: *** You need to add /home/you/go/bin to your $PATH. ***
s/add/make sure/ and s/to/is in/?
that way it's still correct the second time

[adg, 2010-08-24 23:13:35]

LGTM

Hooray for less steps.

On 25 August 2010 03:35,  <rsc@golang.org> wrote:
> Reviewers: adg, r,
>
> Message:
> Hello adg, r (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> build: update, streamline documentation for new $GOBIN
>
> Please review this at http://codereview.appspot.com/2025041/
>
> Affected files:
>  M README
>  M doc/install.html
>
>
>

[rsc, 2010-08-24 23:59:29]

> http://codereview.appspot.com/2025041/diff/8001/9002#newcode47
> doc/install.html:47: optimizer is not enabled.
> s/optimizer/registerizer/ or register allocator?

It does a little more than that, and godoc gc talks
about it as "optimization"

>
> http://codereview.appspot.com/2025041/diff/8001/9002#newcode122
> doc/install.html:122: *** You need to add /home/you/go/bin to your
> $PATH. ***
> s/add/make sure/ and s/to/is in/?
> that way it's still correct the second time

It only prints when the directory is missing from $PATH.

Russ

[rsc, 2010-08-25 00:00:53]

*** Submitted as http://code.google.com/p/go/source/detail?r=0e57b750c3ec ***

build: update, streamline documentation for new $GOBIN

R=adg, r
CC=golang-dev
http://codereview.appspot.com/2025041

[幹你娘, 2020-11-21 03:25:42]

幹你娘