Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3162)

Issue 202460043: Update to the new python-jujuclient 0.50.1.

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 1 month ago by frankban
Modified:
9 years, 1 month ago
Reviewers:
rharding, mp+251253
Visibility:
Public.

Description

Update to the new python-jujuclient 0.50.1. Also update the selenium used for functional test, so that they work with newer versions of firefox. https://code.launchpad.net/~frankban/charms/trusty/juju-gui/new-python-jujuclient/+merge/251253 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update to the new python-jujuclient 0.50.1. #

Patch Set 3 : Update to the new python-jujuclient 0.50.1. #

Total comments: 4

Patch Set 4 : Update to the new python-jujuclient 0.50.1. #

Patch Set 5 : Update to the new python-jujuclient 0.50.1. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -45 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
D deps/jujuclient-0.18.4.tar.gz View 0 chunks +-1 lines, --1 lines 0 comments Download
A deps/jujuclient-0.50.1.tar.gz View 0 chunks +-1 lines, --1 lines 0 comments Download
M server-requirements.pip View 1 chunk +1 line, -1 line 0 comments Download
M server/guiserver/bundles/__init__.py View 1 chunk +2 lines, -3 lines 0 comments Download
M server/guiserver/bundles/views.py View 3 chunks +2 lines, -3 lines 0 comments Download
M server/guiserver/tests/bundles/test_views.py View 6 chunks +6 lines, -7 lines 0 comments Download
M test-requirements.pip View 1 chunk +1 line, -1 line 0 comments Download
M tests/20-functional.test View 6 chunks +7 lines, -7 lines 0 comments Download
M tests/example.py View 3 chunks +30 lines, -25 lines 0 comments Download

Messages

Total messages: 9
frankban
Please take a look.
9 years, 1 month ago (2015-02-27 13:01:59 UTC) #1
rharding
LGTM with one question. https://codereview.appspot.com/202460043/diff/1/test-requirements.pip File test-requirements.pip (right): https://codereview.appspot.com/202460043/diff/1/test-requirements.pip#newcode46 test-requirements.pip:46: selenium==2.45.0 what caused the bump ...
9 years, 1 month ago (2015-02-27 13:18:16 UTC) #2
frankban
On 2015/02/27 13:18:16, rharding wrote: > LGTM with one question. > > https://codereview.appspot.com/202460043/diff/1/test-requirements.pip > File ...
9 years, 1 month ago (2015-02-27 13:20:54 UTC) #3
frankban
Please take a look.
9 years, 1 month ago (2015-02-27 16:54:48 UTC) #4
frankban
Please take a look.
9 years, 1 month ago (2015-02-27 18:39:08 UTC) #5
rharding
Looks like one missing deletion there. Jeff is running another test run with that patch ...
9 years, 1 month ago (2015-02-27 20:57:10 UTC) #6
rharding
With the patch mentioned tests passed for me on a trusty machine. Note that I ...
9 years, 1 month ago (2015-02-27 22:53:34 UTC) #7
frankban
Please take a look. https://codereview.appspot.com/202460043/diff/40001/tests/20-functional.test File tests/20-functional.test (right): https://codereview.appspot.com/202460043/diff/40001/tests/20-functional.test#newcode26 tests/20-functional.test:26: import os On 2015/02/27 22:53:34, ...
9 years, 1 month ago (2015-03-02 11:30:03 UTC) #8
frankban
9 years, 1 month ago (2015-03-02 14:51:35 UTC) #9
*** Submitted:

Update to the new python-jujuclient 0.50.1.

Also update the selenium used for functional test,
so that they work with newer versions of firefox.

R=rharding
CC=
https://codereview.appspot.com/202460043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b