Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(2423)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
201630043
: Parser code clean up. (Closed)
Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 1 month ago by
Joachim Metz
Modified:
9 years, 1 month ago
Reviewers:
kiddi
CC:
log2timeline-dev_googlegroups.com
Visibility:
Public.
More Reviews
Description
.
Patch Set 1
#
Patch Set 2 : Uploading changes made to code.
#
Patch Set 3 : Submitted.
#
Created:
9 years, 1 month ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+440 lines, -298 lines
)
Patch
M
config/dpkg/changelog
View
1
2
1 chunk
+1 line, -1 line
0 comments
Download
M
plaso/__init__.py
View
1
2
1 chunk
+1 line, -1 line
0 comments
Download
M
plaso/lib/utils.py
View
1 chunk
+0 lines, -24 lines
0 comments
Download
M
plaso/parsers/android_app_usage.py
View
3 chunks
+18 lines, -6 lines
0 comments
Download
M
plaso/parsers/bencode_parser.py
View
3 chunks
+26 lines, -29 lines
0 comments
Download
M
plaso/parsers/custom_destinations.py
View
2 chunks
+23 lines, -21 lines
0 comments
Download
M
plaso/parsers/hachoir.py
View
1
3 chunks
+19 lines, -4 lines
0 comments
Download
M
plaso/parsers/java_idx.py
View
1
4 chunks
+22 lines, -8 lines
0 comments
Download
M
plaso/parsers/oxml.py
View
1
2 chunks
+17 lines, -0 lines
0 comments
Download
M
plaso/parsers/pcap.py
View
1
4 chunks
+7 lines, -4 lines
0 comments
Download
M
plaso/parsers/recycler.py
View
5 chunks
+68 lines, -37 lines
0 comments
Download
M
plaso/parsers/recycler_test.py
View
4 chunks
+5 lines, -5 lines
0 comments
Download
M
plaso/parsers/skydrivelogerr.py
View
1
2 chunks
+77 lines, -77 lines
0 comments
Download
M
plaso/parsers/text_parser.py
View
1
19 chunks
+70 lines, -27 lines
0 comments
Download
M
plaso/parsers/winevt.py
View
4 chunks
+16 lines, -4 lines
0 comments
Download
M
plaso/parsers/winevtx.py
View
4 chunks
+15 lines, -4 lines
0 comments
Download
M
plaso/parsers/winfirewall.py
View
2 chunks
+38 lines, -38 lines
0 comments
Download
M
plaso/parsers/winjob.py
View
1
3 chunks
+16 lines, -7 lines
0 comments
Download
M
plaso/parsers/winlnk.py
View
1 chunk
+1 line, -1 line
0 comments
Download
Messages
Total messages: 5
Expand All Messages
|
Collapse All Messages
Joachim Metz
9 years, 1 month ago (2015-02-25 19:05:25 UTC)
#1
Sign in
to reply to this message.
Joachim Metz
Code updated.
9 years, 1 month ago (2015-02-25 19:36:55 UTC)
#2
Code updated.
Sign in
to reply to this message.
Joachim Metz
Code updated.
9 years, 1 month ago (2015-02-25 19:39:29 UTC)
#3
Code updated.
Sign in
to reply to this message.
kiddi
LGTM
9 years, 1 month ago (2015-02-27 22:20:31 UTC)
#4
LGTM
Sign in
to reply to this message.
Joachim Metz
Code Submitted.
9 years, 1 month ago (2015-02-28 07:07:34 UTC)
#5
Code Submitted.
Sign in
to reply to this message.
Expand All Messages
|
Collapse All Messages
Issue 201630043: Parser code clean up. (Closed)
Created 9 years, 1 month ago by Joachim Metz
Modified 9 years, 1 month ago
Reviewers: kiddi
Base URL:
Comments: 0
Recent Issues
|
This issue
This is Rietveld
f62528b