9 years, 3 months ago
(2015-01-15 15:25:47 UTC)
#3
revised.
https://codereview.appspot.com/197790043/diff/1/external_tests/ssl_gtest/ssl_...
File external_tests/ssl_gtest/ssl_loopback_unittest.cc (right):
https://codereview.appspot.com/197790043/diff/1/external_tests/ssl_gtest/ssl_...
external_tests/ssl_gtest/ssl_loopback_unittest.cc:401: info_.sessionID +
info_.sessionIDLength);
On 2015/01/14 23:52:14, mt wrote:
> All this info_ stuff needs to be memset() at some point, doesn't it? What
> distinguishes dirty memory from a valid value otherwise?
Since it's populated by Connect(), Connect() should have failed before we got
here. But I'll memset it.
https://codereview.appspot.com/197790043/diff/1/external_tests/ssl_gtest/ssl_...
external_tests/ssl_gtest/ssl_loopback_unittest.cc:581:
client_->SetSessionCacheEnabled(false);
On 2015/01/14 23:52:14, mt wrote:
> Does this exercise the ticket logic at all? Or both? I'd have expected to
see
> more tests that covered the range of choices for resumption.
This just exercises the ordinary resumption. I guess my thought
was to get some initial resumption-only tests and then do
ticket tests.
Issue 197790043: Session Resumption Unit tests
Created 9 years, 3 months ago by ekr-rietveld
Modified 9 years, 3 months ago
Reviewers: mt
Base URL:
Comments: 4