Issue 197790043: Session Resumption Unit tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 197790043: Session Resumption Unit tests

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 3 months ago by ekr-rietveld

Modified:
9 years, 3 months ago

Reviewers:
mt

Visibility:
Public.

More Reviews

Patch Set 2 : Address MT's comments #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+80 lines, -6 lines)			Patch
	M	external_tests/ssl_gtest/ssl_gtest.cc	View		1 chunk	+5 lines, -4 lines	0 comments	Download
	M	external_tests/ssl_gtest/ssl_loopback_unittest.cc	View	1	9 chunks	+75 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

LGTM https://codereview.appspot.com/197790043/diff/1/external_tests/ssl_gtest/ssl_loopback_unittest.cc File external_tests/ssl_gtest/ssl_loopback_unittest.cc (right): https://codereview.appspot.com/197790043/diff/1/external_tests/ssl_gtest/ssl_loopback_unittest.cc#newcode401 external_tests/ssl_gtest/ssl_loopback_unittest.cc:401: info_.sessionID + info_.sessionIDLength); All this info_ stuff needs ...

9 years, 3 months ago (2015-01-14 23:52:14 UTC) #2

ekr-rietveld

9 years, 3 months ago (2015-01-15 15:25:47 UTC) #3

revised.

https://codereview.appspot.com/197790043/diff/1/external_tests/ssl_gtest/ssl_...
File external_tests/ssl_gtest/ssl_loopback_unittest.cc (right):

https://codereview.appspot.com/197790043/diff/1/external_tests/ssl_gtest/ssl_...
external_tests/ssl_gtest/ssl_loopback_unittest.cc:401: info_.sessionID +
info_.sessionIDLength);
On 2015/01/14 23:52:14, mt wrote:
> All this info_ stuff needs to be memset() at some point, doesn't it?  What
> distinguishes dirty memory from a valid value otherwise?

Since it's populated by Connect(), Connect() should have failed before we got
here. But I'll memset it.

https://codereview.appspot.com/197790043/diff/1/external_tests/ssl_gtest/ssl_...
external_tests/ssl_gtest/ssl_loopback_unittest.cc:581:
client_->SetSessionCacheEnabled(false);
On 2015/01/14 23:52:14, mt wrote:
> Does this exercise the ticket logic at all?  Or both?  I'd have expected to
see
> more tests that covered the range of choices for resumption.

This just exercises the ordinary resumption. I guess my thought
was to get some initial resumption-only tests and then do
ticket tests.

Expand All Messages | Collapse All Messages