Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2011)

Issue 196058: Redo ASCII and pcap Traces

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by craigdo
Modified:
11 years, 7 months ago
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Patch Set 1 #

Total comments: 20
Unified diffs Side-by-side diffs Delta from patch set Stats (+9212 lines, -2345 lines) Patch
M CHANGES.html View 1 chunk +57 lines, -0 lines 0 comments Download
M bindings/python/apidefs/gcc-ILP32/ns3_module_common.py View 3 chunks +86 lines, -0 lines 0 comments Download
M bindings/python/apidefs/gcc-ILP32/ns3_module_core.py View 2 chunks +16 lines, -1 line 0 comments Download
M bindings/python/apidefs/gcc-ILP32/ns3_module_csma.py View 2 chunks +5 lines, -5 lines 0 comments Download
M bindings/python/apidefs/gcc-ILP32/ns3_module_emu.py View 1 chunk +5 lines, -0 lines 0 comments Download
M bindings/python/apidefs/gcc-ILP32/ns3_module_helper.py View 19 chunks +730 lines, -450 lines 0 comments Download
M bindings/python/apidefs/gcc-ILP32/ns3_module_mobility.py View 1 chunk +1 line, -1 line 0 comments Download
M bindings/python/apidefs/gcc-ILP32/ns3_module_node.py View 3 chunks +143 lines, -0 lines 0 comments Download
M bindings/python/apidefs/gcc-ILP32/ns3_module_point_to_point.py View 1 chunk +5 lines, -0 lines 0 comments Download
M bindings/python/apidefs/gcc-ILP32/ns3_module_wifi.py View 3 chunks +7 lines, -2 lines 0 comments Download
M bindings/python/apidefs/gcc-LP64/ns3_module_common.py View 3 chunks +86 lines, -0 lines 0 comments Download
M bindings/python/apidefs/gcc-LP64/ns3_module_core.py View 1 chunk +15 lines, -0 lines 0 comments Download
M bindings/python/apidefs/gcc-LP64/ns3_module_csma.py View 2 chunks +5 lines, -5 lines 0 comments Download
M bindings/python/apidefs/gcc-LP64/ns3_module_emu.py View 1 chunk +5 lines, -0 lines 0 comments Download
M bindings/python/apidefs/gcc-LP64/ns3_module_helper.py View 19 chunks +730 lines, -450 lines 0 comments Download
M bindings/python/apidefs/gcc-LP64/ns3_module_mobility.py View 1 chunk +1 line, -1 line 0 comments Download
M bindings/python/apidefs/gcc-LP64/ns3_module_node.py View 3 chunks +143 lines, -0 lines 0 comments Download
M bindings/python/apidefs/gcc-LP64/ns3_module_point_to_point.py View 1 chunk +5 lines, -0 lines 0 comments Download
M bindings/python/apidefs/gcc-LP64/ns3_module_wifi.py View 3 chunks +7 lines, -2 lines 0 comments Download
M bindings/python/ns3modulescan.py View 1 chunk +2 lines, -2 lines 2 comments Download
M doc/manual/tracing.texi View 2 chunks +831 lines, -0 lines 0 comments Download
M doc/tutorial/building-topologies.texi View 3 chunks +7 lines, -7 lines 0 comments Download
M doc/tutorial/tracing.texi View 8 chunks +1087 lines, -6 lines 0 comments Download
M doc/tutorial/tweaking.texi View 3 chunks +20 lines, -22 lines 0 comments Download
M examples/csma/csma-bridge.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M examples/csma/csma-bridge.py View 1 chunk +1 line, -1 line 0 comments Download
M examples/csma/csma-bridge-one-hop.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M examples/csma/csma-broadcast.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M examples/csma/csma-multicast.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M examples/csma/csma-one-subnet.cc View 1 chunk +11 lines, -8 lines 0 comments Download
M examples/csma/csma-packet-socket.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M examples/csma/csma-star.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/emulation/emu-ping.cc View 1 chunk +2 lines, -1 line 0 comments Download
M examples/emulation/emu-udp-echo.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/error-model/simple-error-model.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M examples/ipv6/fragmentation-ipv6.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M examples/ipv6/icmpv6-redirect.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M examples/ipv6/loose-routing-ipv6.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M examples/ipv6/ping6.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M examples/ipv6/radvd.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M examples/ipv6/radvd-two-prefix.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M examples/naming/object-names.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M examples/realtime/realtime-udp-echo.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M examples/routing/dynamic-global-routing.cc View 1 chunk +8 lines, -7 lines 0 comments Download
M examples/routing/global-injection-slash32.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M examples/routing/global-routing-slash32.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M examples/routing/mixed-global-routing.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M examples/routing/simple-alternate-routing.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M examples/routing/simple-global-routing.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M examples/routing/simple-point-to-point-olsr.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M examples/routing/simple-routing-ping6.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M examples/routing/static-routing-slash32.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M examples/socket/socket-bound-static-routing.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M examples/socket/socket-bound-tcp-static-routing.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M examples/tap/tap-csma.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/tap/tap-wifi-dumbbell.cc View 1 chunk +2 lines, -1 line 0 comments Download
M examples/tcp/star.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/tcp/tcp-large-transfer.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M examples/tcp/tcp-nsc-lfn.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/tcp/tcp-nsc-zoo.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/tcp/tcp-star-server.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M examples/tunneling/virtual-net-device.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M examples/tutorial/second.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A examples/tutorial/sixth.cc View 1 chunk +231 lines, -0 lines 0 comments Download
M examples/tutorial/third.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/tutorial/wscript View 1 chunk +3 lines, -0 lines 0 comments Download
M examples/udp/udp-echo.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M examples/wireless/mixed-wireless.cc View 1 chunk +15 lines, -9 lines 0 comments Download
M examples/wireless/multirate.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M examples/wireless/wifi-simple-adhoc.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/wireless/wifi-simple-adhoc-grid.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M examples/wireless/wifi-simple-infra.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/wireless/wifi-simple-interference.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/wireless/wifi-wired-bridging.cc View 1 chunk +1 line, -1 line 0 comments Download
A src/common/output-stream-object.h View 1 chunk +89 lines, -0 lines 3 comments Download
A src/common/output-stream-object.cc View 1 chunk +61 lines, -0 lines 0 comments Download
A src/common/pcap-file-object.h View 1 chunk +68 lines, -0 lines 2 comments Download
A src/common/pcap-file-object.cc View 1 chunk +133 lines, -0 lines 3 comments Download
M src/common/wscript View 2 chunks +4 lines, -0 lines 0 comments Download
M src/devices/csma/csma-net-device.h View 2 chunks +7 lines, -10 lines 0 comments Download
M src/devices/emu/emu-net-device.h View 2 chunks +8 lines, -10 lines 0 comments Download
M src/devices/point-to-point/point-to-point-net-device.h View 2 chunks +7 lines, -10 lines 0 comments Download
M src/helper/csma-helper.h View 3 chunks +29 lines, -118 lines 0 comments Download
M src/helper/csma-helper.cc View 4 chunks +95 lines, -124 lines 0 comments Download
M src/helper/emu-helper.h View 3 chunks +32 lines, -132 lines 0 comments Download
M src/helper/emu-helper.cc View 3 chunks +85 lines, -144 lines 0 comments Download
M src/helper/internet-stack-helper.h View 5 chunks +67 lines, -72 lines 0 comments Download
M src/helper/internet-stack-helper.cc View 3 chunks +522 lines, -104 lines 0 comments Download
M src/helper/ipv4-interface-container.h View 3 chunks +63 lines, -1 line 0 comments Download
M src/helper/ipv4-interface-container.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M src/helper/ipv6-interface-container.h View 2 chunks +62 lines, -2 lines 0 comments Download
M src/helper/ipv6-interface-container.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M src/helper/node-container.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/helper/point-to-point-helper.h View 3 chunks +34 lines, -113 lines 0 comments Download
M src/helper/point-to-point-helper.cc View 4 chunks +93 lines, -126 lines 0 comments Download
A src/helper/trace-helper.h View 1 chunk +1129 lines, -0 lines 4 comments Download
A src/helper/trace-helper.cc View 1 chunk +1165 lines, -0 lines 0 comments Download
M src/helper/wifi-helper.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/helper/wscript View 2 chunks +2 lines, -0 lines 0 comments Download
M src/helper/yans-wifi-helper.h View 4 chunks +44 lines, -103 lines 2 comments Download
M src/helper/yans-wifi-helper.cc View 4 chunks +267 lines, -125 lines 0 comments Download
M src/internet-stack/ipv4-l3-protocol.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/internet-stack/ipv4-l3-protocol.cc View 11 chunks +18 lines, -18 lines 0 comments Download
A src/node/radiotap-header.h View 1 chunk +273 lines, -0 lines 4 comments Download
A src/node/radiotap-header.cc View 1 chunk +404 lines, -0 lines 0 comments Download
M src/node/wscript View 2 chunks +2 lines, -0 lines 0 comments Download
M src/test/ns3tcp/ns3tcp-cwnd-test-suite.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/test/ns3tcp/ns3tcp-interop-test-suite.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/test/ns3wifi/wifi-interference-test-suite.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10
Mathieu Lacage
nothing to add beyond the small comments below. http://codereview.appspot.com/196058/diff/1/77 File src/common/output-stream-object.h (right): http://codereview.appspot.com/196058/diff/1/77#newcode72 src/common/output-stream-object.h:72: class ...
11 years, 8 months ago (2010-01-29 10:29:29 UTC) #1
gjcarneiro
http://codereview.appspot.com/196058/diff/1/21 File bindings/python/ns3modulescan.py (right): http://codereview.appspot.com/196058/diff/1/21#newcode153 bindings/python/ns3modulescan.py:153: #if pygccxml_definition.name.endswith('Helper'): Do you really think users should be ...
11 years, 8 months ago (2010-01-30 15:45:33 UTC) #2
Tom Henderson
I support the new architecture and API. I mainly reviewed the new documentation (nice job) ...
11 years, 7 months ago (2010-01-30 22:25:50 UTC) #3
craigdo
http://codereview.appspot.com/196058/diff/1/21 File bindings/python/ns3modulescan.py (right): http://codereview.appspot.com/196058/diff/1/21#newcode153 bindings/python/ns3modulescan.py:153: #if pygccxml_definition.name.endswith('Helper'): The issue is whether or not the ...
11 years, 7 months ago (2010-02-01 21:15:11 UTC) #4
craigdo
Will add doxygen to PcapFileObject
11 years, 7 months ago (2010-02-01 21:18:27 UTC) #5
Mathieu Lacage
On Mon, Feb 1, 2010 at 10:15 PM, <craigdo@gmail.com> wrote: > http://codereview.appspot.com/196058/diff/1/77#newcode72 > src/common/output-stream-object.h:72: class ...
11 years, 7 months ago (2010-02-02 09:11:30 UTC) #6
gjcarneiro
On Tue, Feb 2, 2010 at 9:11 AM, Mathieu Lacage <mathieu.lacage@gmail.com>wrote: > > > On ...
11 years, 7 months ago (2010-02-02 10:52:35 UTC) #7
craigdo1
>>http://codereview.appspot.com/196058/diff/1/77#newcode72 >>src/common/output-stream-object.h:72: class OutputStreamObject : public Object > >>Deriving from Object means that a user ...
11 years, 7 months ago (2010-02-02 20:07:27 UTC) #8
Tom Henderson
FWIW, here are my opinions on what seem to be the contentious issues. http://codereview.appspot.com/196058/diff/1/77 File ...
11 years, 7 months ago (2010-02-03 15:05:10 UTC) #9
gjcarneiro
11 years, 7 months ago (2010-02-03 15:12:31 UTC) #10
I like the introduction of an OutputStreamObject class. It fixes an old
Python bindings bug (Bug 155 - "std::ostream & os" parameters not Python
friendly).

On Wed, Feb 3, 2010 at 3:05 PM, <tomh.org@gmail.com> wrote:

> FWIW, here are my opinions on what seem to be the contentious issues.
>
>
>
> http://codereview.appspot.com/196058/diff/1/77
> File src/common/output-stream-object.h (right):
>
>
> http://codereview.appspot.com/196058/diff/1/77#newcode72
> src/common/output-stream-object.h:72: class OutputStreamObject : public
> Object
> On 2010/02/01 21:15:11, craigdo wrote:
>
>> Deriving from Object means that a user can derive from something low
>>
> level
>
>> enough but relatively familiar and documented without having to go
>>
> into gory
>
>> details about something new.
>>
>
>
>
> Although I do not care whether this class ends up deriving from Object
> or not, I would have chosen reference counting base class for the
> following reasons:
>
> 1) I don't think the non-Object base class is a foreign concept (we use
> it elsewhere such as Ipv{4|6}Route, and AsciiWriter, and should use
> where applicable).  I think there may be legacy uses in the system that
> predate the introduction of the alternative base classes (such as
> PcapWriter).  It is clearly documented, if you need attributes and
> aggregation, use Object; if you don't need these features, we provide
> other base classes.
>
> 2) I didn't find the possible use case of aggregating stream objects to
> a node (note that we can only aggregate one instance) that likely.  I
> think that if such a need arises, one could create a
> StreamContainerObject : public Object and aggregate that.
>
>
> Regarding the class as a whole, I think it is useful to have just to
> encapsulate references to stream as exemplified in sixth.cc.  Rather
> than reuse AsciiWriter, I thought that perhaps AsciiWriter could inherit
> from this class, until I learned this morning that AsciiWriter is slated
> for deletion.
>
>
> http://codereview.appspot.com/196058/diff/1/78
> File src/common/pcap-file-object.cc (right):
>
>
> http://codereview.appspot.com/196058/diff/1/78#newcode75
> src/common/pcap-file-object.cc:75: p->CopyData (buffer, bufferSize);
> On 2010/02/01 21:15:11, craigdo wrote:
>
>> I want to do block I/O here since it is block I/O.  Similar things
>>
> need to
>
>> happen in emu and tap at least.
>>
>
>
> I don't have a strong opinion here since the test cases show 1%
> improvement in avoiding the allocation/copy.  I don't see why we
> wouldn't just put in the faster variant and leave a comment that "this
> architecturally should use block I/O but the below is optimized to avoid
> extra allocation/copy".
>
> http://codereview.appspot.com/196058/diff/1/98
> File src/helper/trace-helper.h (right):
>
> http://codereview.appspot.com/196058/diff/1/98#newcode57
> src/helper/trace-helper.h:57: enum {DLT_IEEE802_11_RADIO = 127};
> I favor using the DLT_ constants as introduced by Craig, although I will
> be fine with either.
>
> http://codereview.appspot.com/196058/diff/1/98#newcode940
> src/helper/trace-helper.h:940: class TraceHelperForProtocol : public
> PcapAndAsciiHelperForIpv4AndPcapHelperForIpv6
> I don't have a strong opinion about mixins vs lumping all of this
> together (seems like both could be made to work adequately), other than
> I agree that the above is pretty horrific and should be fixed somehow.
>
> http://codereview.appspot.com/196058/show
>



-- 
Gustavo J. A. M. Carneiro
INESC Porto, Telecommunications and Multimedia Unit
"The universe is always one step beyond logic." -- Frank Herbert
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b