Issue 194770043: compare LilyPond Rationals without unnecessary overflow; issue 4180

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 194770043: compare LilyPond Rationals without unnecessary overflow; issue 4180

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 4 months ago by Keith

Modified:
9 years, 3 months ago

Reviewers:
Dan Eble, Trevor Daniels

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

optimized, but vulnerable (before patch) percussion part real 0m28.881s user 0m27.170s sys 0m0.707s piano real 0m21.976s user 0m21.120s sys 0m0.311s straightforward (after patch) percussion part real 0m28.807s user 0m27.199s sys 0m0.732s piano real 0m22.057s user 0m21.199s sys 0m0.322s

Patch Set 1 #

Total comments: 1

Patch Set 2 : inf and zero tests are fine #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	flower/rational.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Keith

https://codereview.appspot.com/194770043/diff/1/flower/rational.cc File flower/rational.cc (left): https://codereview.appspot.com/194770043/diff/1/flower/rational.cc#oldcode222 flower/rational.cc:222: return 0; Here we have already determined that r ...

9 years, 4 months ago (2014-12-28 08:13:59 UTC) #1

LGTM

Expand All Messages | Collapse All Messages