Other than the performance regression this looks ok. http://codereview.appspot.com/194166/diff/1/4 File epgp.lua (right): http://codereview.appspot.com/194166/diff/1/4#newcode600 epgp.lua:600: return ...
14 years, 2 months ago
(2010-01-31 19:52:27 UTC)
#1
Other than the performance regression this looks ok.
http://codereview.appspot.com/194166/diff/1/4
File epgp.lua (right):
http://codereview.appspot.com/194166/diff/1/4#newcode600
epgp.lua:600: return UnitInRaid("player") and (use_group_standby or
selected[name])
This is going to end up quadradic on the number of raid members (there is a loop
on raidmembers that calls this for each one of them). We need some kind of cache
of groups here that will be updated on RAID_ROSTER_UPDATE and make this query
O(1).
Alternatively, we can change the API into:
function EPGP:BuildExtrasTable(t)
t = t or {}
-- build a table of t["name"] = true for each member in the extras list
return t
end
Issue 194166: epgp group 6-8 standby
Created 14 years, 2 months ago by chip.turner
Modified 2 years, 3 months ago
Reviewers: alkis_evlogimenos.com
Base URL: http://epgp.googlecode.com/svn/trunk/
Comments: 1