Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(284)

Issue 194166: epgp group 6-8 standby

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by chip.turner
Modified:
3 weeks, 3 days ago
Reviewers:
alkis
Base URL:
http://epgp.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -4 lines) Patch
M epgp.lua View 2 chunks +12 lines, -3 lines 1 comment Download
M localization/localization.enUS.lua View 3 chunks +3 lines, -1 line 0 comments Download
M whisper.lua View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 1
evlogimenos
11 years, 11 months ago (2010-01-31 19:52:27 UTC) #1
Other than the performance regression this looks ok.

http://codereview.appspot.com/194166/diff/1/4
File epgp.lua (right):

http://codereview.appspot.com/194166/diff/1/4#newcode600
epgp.lua:600: return UnitInRaid("player") and (use_group_standby or
selected[name])
This is going to end up quadradic on the number of raid members (there is a loop
on raidmembers that calls this for each one of them). We need some kind of cache
of groups here that will be updated on RAID_ROSTER_UPDATE and make this query
O(1).

Alternatively, we can change the API into:

function EPGP:BuildExtrasTable(t)
  t = t or {}
  -- build a table of t["name"] = true for each member in the extras list
  return t
end
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b