Adding system idle power draw test.

Adding system idle power draw test.

Also re-wrote the battery stat collection function of the power status
library. It now scrapes the battery sysfs to collect battery stats
instead of getting them from devkit-power. This change was required
because devkit-power's energy-rate is inaccurate since it doesn't
take the current battery voltage into account.

[petkov, 2010-01-25 23:15:03]

LGTM with a few comment -- feel free to fix or not fix.

http://codereview.appspot.com/194065/diff/1/2
File client/common_lib/site_power_status.py (right):

http://codereview.appspot.com/194065/diff/1/2#newcode1
client/common_lib/site_power_status.py:1: import logging, re, os, glob
Sort.

http://codereview.appspot.com/194065/diff/1/2#newcode2
client/common_lib/site_power_status.py:2: from autotest_lib.client.common_lib
import utils, error
Sort.

http://codereview.appspot.com/194065/diff/1/2#newcode30
client/common_lib/site_power_status.py:30: def __init__(self, fields, path =
None):
No spaces around = per PEP-8.

http://codereview.appspot.com/194065/diff/1/2#newcode30
client/common_lib/site_power_status.py:30: def __init__(self, fields, path =
None):
You could call read_all_vals here and then call update, and leave update as pass
(or unimplemented) in the base class.

http://codereview.appspot.com/194065/diff/1/2#newcode81
client/common_lib/site_power_status.py:81: def __init__(self, path = None):
No spaces around = per PEP-8.

http://codereview.appspot.com/194065/diff/1/2#newcode115
client/common_lib/site_power_status.py:115: def __init__(self, path = None):
No spaces around = per PEP-8.

http://codereview.appspot.com/194065/diff/1/2#newcode144
client/common_lib/site_power_status.py:144: raise error.TestError('Battery or
Linepower path not found')
Maybe define and raise:

class PowerStatusError(error.AutoservHostError):
    pass

http://codereview.appspot.com/194065/diff/1/4
File client/site_tests/system_PowerIdle/system_PowerIdle.py (right):

http://codereview.appspot.com/194065/diff/1/4#newcode7
client/site_tests/system_PowerIdle/system_PowerIdle.py:7: from
autotest_lib.client.common_lib import site_power_status, error
Sort.

http://codereview.appspot.com/194065/diff/1/4#newcode21
client/site_tests/system_PowerIdle/system_PowerIdle.py:21: def warmup(self,
warmup_time = 60):
No spaces around =

http://codereview.appspot.com/194065/diff/1/4#newcode25
client/site_tests/system_PowerIdle/system_PowerIdle.py:25: def run_once(self,
idle_time = 120):
No spaces around =

http://codereview.appspot.com/194065/diff/1/4#newcode26
client/site_tests/system_PowerIdle/system_PowerIdle.py:26: time.sleep(idle_time)
For consistency, kill chrome, turn display off?

http://codereview.appspot.com/194065/diff/1/4#newcode32
client/site_tests/system_PowerIdle/system_PowerIdle.py:32:
keyvals['charge_full'] = self.status.battery[0].charge_full
I think our "convention" is to start with the units for each metric.

[Sameer, 2010-01-25 23:55:28]

PTAL.

http://codereview.appspot.com/194065/diff/1/2
File client/common_lib/site_power_status.py (right):

http://codereview.appspot.com/194065/diff/1/2#newcode1
client/common_lib/site_power_status.py:1: import logging, re, os, glob
On 2010/01/25 23:15:03, petkov wrote:
> Sort.
> 

Done.

http://codereview.appspot.com/194065/diff/1/2#newcode2
client/common_lib/site_power_status.py:2: from autotest_lib.client.common_lib
import utils, error
On 2010/01/25 23:15:03, petkov wrote:
> Sort.
> 

Done.

http://codereview.appspot.com/194065/diff/1/2#newcode30
client/common_lib/site_power_status.py:30: def __init__(self, fields, path =
None):
On 2010/01/25 23:15:03, petkov wrote:
> No spaces around = per PEP-8.
> 

Done.

http://codereview.appspot.com/194065/diff/1/2#newcode81
client/common_lib/site_power_status.py:81: def __init__(self, path = None):
On 2010/01/25 23:15:03, petkov wrote:
> No spaces around = per PEP-8.

Done.

http://codereview.appspot.com/194065/diff/1/2#newcode115
client/common_lib/site_power_status.py:115: def __init__(self, path = None):
On 2010/01/25 23:15:03, petkov wrote:
> No spaces around = per PEP-8.

Done.

http://codereview.appspot.com/194065/diff/1/4
File client/site_tests/system_PowerIdle/system_PowerIdle.py (right):

http://codereview.appspot.com/194065/diff/1/4#newcode7
client/site_tests/system_PowerIdle/system_PowerIdle.py:7: from
autotest_lib.client.common_lib import site_power_status, error
On 2010/01/25 23:15:03, petkov wrote:
> Sort.
> 

Done.

http://codereview.appspot.com/194065/diff/1/4#newcode21
client/site_tests/system_PowerIdle/system_PowerIdle.py:21: def warmup(self,
warmup_time = 60):
On 2010/01/25 23:15:03, petkov wrote:
> No spaces around =

Done.

http://codereview.appspot.com/194065/diff/1/4#newcode25
client/site_tests/system_PowerIdle/system_PowerIdle.py:25: def run_once(self,
idle_time = 120):
On 2010/01/25 23:15:03, petkov wrote:
> No spaces around =
> 

Done.

http://codereview.appspot.com/194065/diff/1/4#newcode26
client/site_tests/system_PowerIdle/system_PowerIdle.py:26: time.sleep(idle_time)
Good point.  Will address this and other things like network activity that may
impact the measured power, in another CL, though.

On 2010/01/25 23:15:03, petkov wrote:
> For consistency, kill chrome, turn display off?
>

http://codereview.appspot.com/194065/diff/1/4#newcode32
client/site_tests/system_PowerIdle/system_PowerIdle.py:32:
keyvals['charge_full'] = self.status.battery[0].charge_full
On 2010/01/25 23:15:03, petkov wrote:
> I think our "convention" is to start with the units for each metric.

Done.

[petkov, 2010-01-25 23:57:56]

LGTM