Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(382)

Issue 194065: Adding system idle power draw test.

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 9 months ago by Sameer
Modified:
1 month, 1 week ago
Reviewers:
petkov
Visibility:
Public.

Description

Adding system idle power draw test. Also re-wrote the battery stat collection function of the power status library. It now scrapes the battery sysfs to collect battery stats instead of getting them from devkit-power. This change was required because devkit-power's energy-rate is inaccurate since it doesn't take the current battery voltage into account.

Patch Set 1 #

Total comments: 22

Patch Set 2 : Modifications based on code review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -66 lines) Patch
M client/common_lib/site_power_status.py View 1 7 chunks +81 lines, -66 lines 0 comments Download
A client/site_tests/system_PowerIdle/control View 1 chunk +16 lines, -0 lines 0 comments Download
A client/site_tests/system_PowerIdle/system_PowerIdle.py View 1 1 chunk +44 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Sameer
8 years, 9 months ago (2010-01-25 22:15:05 UTC) #1
petkov
LGTM with a few comment -- feel free to fix or not fix. http://codereview.appspot.com/194065/diff/1/2 File ...
8 years, 9 months ago (2010-01-25 23:15:03 UTC) #2
Sameer
PTAL. http://codereview.appspot.com/194065/diff/1/2 File client/common_lib/site_power_status.py (right): http://codereview.appspot.com/194065/diff/1/2#newcode1 client/common_lib/site_power_status.py:1: import logging, re, os, glob On 2010/01/25 23:15:03, ...
8 years, 9 months ago (2010-01-25 23:55:28 UTC) #3
petkov
8 years, 9 months ago (2010-01-25 23:57:56 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b