Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(749)

Issue 193098: Review: bug fix with shaders that have no 'main' instructions (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years ago by larrygritz
Modified:
13 years ago
Reviewers:
ckulla
CC:
dev-osl_imageworks.com, osl-dev_googlegroups.com
Base URL:
http://openshadinglanguage.googlecode.com/svn/trunk/
Visibility:
Public.

Description

It's possible to write a shader that has no instructions in the main program, but merely shuffles input params into output params (this is in fact done for certain "glue nodes" in shader networks). Due to a bug (mine), we never set the master's "maincodebegin" and "maincodeend" members, unless there actually was main code (which is the case for 99% of shaders, but...). Hilarity ensues. And multi-day bug hunts. Simple fix attached to initialize these, as well as a couple DASSERTS that I may as well leave in.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
src/liboslexec/exec.cpp View 1 chunk +1 line, -0 lines 0 comments Download
src/liboslexec/loadshader.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
src/liboslexec/master.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2
larrygritz
13 years ago (2010-01-26 02:07:16 UTC) #1
ckulla
13 years ago (2010-01-26 02:29:29 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b