Issue 192290043: Rev version for smoke due to breaking change switching the maximum number of args handled from 3 to…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 192290043: Rev version for smoke due to breaking change switching the maximum number of args handled from 3 to… (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 3 months ago by jacobr

Modified:
9 years, 3 months ago

Reviewers:
sigmund

Base URL:
git@github.com:dart-lang/smoke.git@master

Visibility:
Public.

More Reviews

Description

Rev version for smoke due to breaking change switching the maximum number of args handled from 3 to 15 BUG= R=sigmund@google.com Committed: 260498e09d333e96ac40e44e9f591828a26e3807

Patch Set 1 #

Patch Set 2 : ptal #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	CHANGELOG.md	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
	M	pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

sigmund

lgtm - maybe add an entry in the CHANGELOG.md to say what changed?

9 years, 3 months ago (2015-01-15 18:17:55 UTC) #2

jacobr

On 2015/01/15 18:17:55, sigmund wrote: > lgtm - maybe add an entry in the CHANGELOG.md ...

9 years, 3 months ago (2015-01-15 18:21:40 UTC) #3

jacobr

9 years, 3 months ago (2015-01-15 18:23:56 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
260498e09d333e96ac40e44e9f591828a26e3807 (presubmit successful).

Expand All Messages | Collapse All Messages