Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(506)

Issue 1914043: Adds announce-end-grob to engraver-scheme.cc (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 10 months ago by MikeSol
Modified:
8 years, 2 months ago
Reviewers:
lemzwerg, Neil Puttock
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Adds announce-end-grob to engraver-scheme.cc Adds announce-end-grob to engraver-scheme.cc Return value fix

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixes trailing whitespace issues #

Total comments: 8

Patch Set 3 : Indentation, clarity, and type testing fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
M lily/engraver-scheme.cc View 1 2 2 chunks +19 lines, -4 lines 0 comments Download

Messages

Total messages: 6
lemzwerg
http://codereview.appspot.com/1914043/diff/1/2 File lily/engraver-scheme.cc (right): http://codereview.appspot.com/1914043/diff/1/2#newcode47 lily/engraver-scheme.cc:47: { Please don't use trailing spaces in strings. Instead, ...
8 years, 10 months ago (2010-08-02 12:34:24 UTC) #1
MikeSol
http://codereview.appspot.com/1914043/diff/1/2 File lily/engraver-scheme.cc (right): http://codereview.appspot.com/1914043/diff/1/2#newcode47 lily/engraver-scheme.cc:47: { On 2010/08/02 12:34:25, lemzwerg wrote: > Please don't ...
8 years, 10 months ago (2010-08-02 12:40:48 UTC) #2
lemzwerg
Please do whatever is most convenient to you.
8 years, 10 months ago (2010-08-02 13:24:42 UTC) #3
Neil Puttock
http://codereview.appspot.com/1914043/diff/6001/7001 File lily/engraver-scheme.cc (right): http://codereview.appspot.com/1914043/diff/6001/7001#newcode26 lily/engraver-scheme.cc:26: " with give @code{grob_name}, a symbol. @code{cause}" with given ...
8 years, 10 months ago (2010-08-02 22:56:25 UTC) #4
MikeSol
http://codereview.appspot.com/1914043/diff/6001/7001 File lily/engraver-scheme.cc (right): http://codereview.appspot.com/1914043/diff/6001/7001#newcode26 lily/engraver-scheme.cc:26: " with give @code{grob_name}, a symbol. @code{cause}" On 2010/08/02 ...
8 years, 10 months ago (2010-08-03 08:36:36 UTC) #5
Neil Puttock
8 years, 10 months ago (2010-08-04 18:32:33 UTC) #6
LGTM, pushed to master.

Cheers,
Neil
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b