Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(16937)

Issue 191370043: Issue 4233: Improve partcombine multi-measure rest handling. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 3 months ago by Dan Eble
Modified:
9 years, 3 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

So, for the first time in about eight years, I compose a piece in which I want to use the plain old partcombine command, and it happens to demonstrate some known deficiencies. This scratches the itch. Add "silence1" and "silence2" states which constrain the partcombine iterator to take events from a specific part during intervals of silence. These new states allow the following improvements. Detect when a multi-measure rest starts in the middle of a multi-measure rest in the other voice and engrave it as a shared rest. Previously, the new rest would have been engraved as a voice-specific rest. In solo analysis, when a rest and a multi-measure rest begin simultaneously, engrave the rest as a shared rest and omit the multi-measure rest. Previously, both rests would have been engraved as voice-specific rests. A regression test has been changed just to remove "!!!" markers which were drawing attention to recognized undesirable output that is no longer a problem.

Patch Set 1 #

Patch Set 2 : style #

Patch Set 3 : revise texidoc in regtest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -74 lines) Patch
M input/regression/part-combine-mmrest-after-apart-silence.ly View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M lily/part-combine-iterator.cc View 11 chunks +55 lines, -38 lines 0 comments Download
M scm/part-combiner.scm View 1 7 chunks +119 lines, -33 lines 0 comments Download

Messages

Total messages: 3
Dan Eble
style
9 years, 3 months ago (2014-12-29 04:19:38 UTC) #1
Dan Eble
9 years, 3 months ago (2014-12-29 04:21:32 UTC) #2
Dan Eble
9 years, 3 months ago (2014-12-29 14:28:45 UTC) #3
revise texidoc in regtest
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b