Issue 187140044: docstring

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 187140044: docstring

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 4 months ago by Keith

Modified:
9 years, 4 months ago

Reviewers:
lemzwerg

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

docstring

Patch Set 1 #

Patch Set 2 : docstring the debug markup with arrows #

Total comments: 3

Patch Set 3 : context #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -2 lines)			Patch
	M	lily/paper-column.cc	View		1 chunk	+7 lines, -1 line	0 comments	Download
	M	lily/separation-item.cc	View		1 chunk	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

lemzwerg

9 years, 4 months ago (2014-12-14 06:54:56 UTC) #1

Some nits.  Thanks for adding this!

https://codereview.appspot.com/187140044/diff/20001/lily/separation-item.cc
File lily/separation-item.cc (right):

https://codereview.appspot.com/187140044/diff/20001/lily/separation-item.cc#n...
lily/separation-item.cc:190: "Draws the @code{horizontal-sklines} of each
@code{PaperColumn},"
s/sklines/skylines/

https://codereview.appspot.com/187140044/diff/20001/lily/separation-item.cc#n...
lily/separation-item.cc:191: " showing the shapes used to the minimum distances
between"
`used to'?  This sentence looks weird...

https://codereview.appspot.com/187140044/diff/20001/lily/separation-item.cc#n...
lily/separation-item.cc:193: " before staves have been spaced on the page.")
s/have been spaced/ have been spaced (vertically)/

Expand All Messages | Collapse All Messages