Issue 186530043: skyline.cc: merge algorithm terminates independent of floating-point

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 186530043: skyline.cc: merge algorithm terminates independent of floating-point

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 4 months ago by Keith

Modified:
9 years, 3 months ago

Reviewers:
lemzwerg

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

skyline.cc: merge algorithm terminates independent of floating-point skyline.cc: first_intersection algorithm more robust to optimized floating-point skyline.cc: remove deholify skyline.cc: make the merge algorithm a single loop

Patch Set 1 #

Total comments: 2

Patch Set 2 : undeholify #

Patch Set 3 : remove unrelated patch #

Patch Set 4 : make merge_skylines use a single loop #

Patch Set 5 : drop zero-width building on the end of the list #

Patch Set 6 : no need to handle empties #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+67 lines, -137 lines)			Patch
M	lily/include/skyline.hh	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	lily/include/skyline-pair.hh	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	lily/skyline.cc	View	6 chunks	+66 lines, -125 lines	0 comments	Download
M	lily/skyline-pair.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	lily/stencil-integral.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

lemzwerg

LGTM https://codereview.appspot.com/186530043/diff/1/lily/skyline.cc File lily/skyline.cc (right): https://codereview.appspot.com/186530043/diff/1/lily/skyline.cc#newcode249 lily/skyline.cc:249: printf ("We are here"); Debugging remnants?

9 years, 4 months ago (2014-12-22 04:25:43 UTC) #1

Keith

https://codereview.appspot.com/186530043/diff/1/lily/skyline.cc File lily/skyline.cc (right): https://codereview.appspot.com/186530043/diff/1/lily/skyline.cc#newcode249 lily/skyline.cc:249: printf ("We are here"); On 2014/12/22 04:25:43, lemzwerg wrote: ...

9 years, 4 months ago (2014-12-22 04:58:08 UTC) #2

lemzwerg

LGTM. Maybe it makes sense to commit the removal of the `deholify' stuff separately.

9 years, 4 months ago (2014-12-22 06:10:48 UTC) #3

Keith

9 years, 3 months ago (2014-12-24 22:36:42 UTC) #4

On 2014/12/22 06:10:48, lemzwerg wrote:
> LGTM.  Maybe it makes sense to commit the removal of the `deholify' stuff
> separately.

Yes. There were three commits with header lines as in the Description here.
Now there are four.
A single loop merging skylines one building at a time runs 1% faster with 3%
less memory so let's just do that.

Expand All Messages | Collapse All Messages