Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2595)

Issue 186244: iscameraray and isshadowray (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by larrygritz
Modified:
12 years, 10 months ago
Reviewers:
ckulla
Base URL:
http://openshadinglanguage.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Simple implementations. New fields in the ShaderGlobals that need to be set by the caller. SPI folks: I'll have a separate review internally for the renderer-side part of it.

Patch Set 1 #

Patch Set 2 : raylevel and isshadowray #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -7 lines) Patch
M src/include/oslexec.h View 1 2 chunks +6 lines, -2 lines 0 comments Download
M src/liboslcomp/typecheck.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M src/liboslexec/master.cpp View 1 2 chunks +3 lines, -1 line 0 comments Download
M src/liboslexec/opattribute.cpp View 1 1 chunk +41 lines, -0 lines 0 comments Download
M src/liboslexec/oslops.h View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 1
ckulla
12 years, 10 months ago (2010-01-22 21:36:40 UTC) #1
LGTM

(I think you forgot to put any reviewers on the review)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b