Issue 18600045: cmd/juju: use API for expose/unexpose

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 18600045: cmd/juju: use API for expose/unexpose

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by axw

Modified:
10 years, 5 months ago

Reviewers:
john2, mp+193562, wallyworld

Visibility:
Public.

Description

cmd/juju: use API for expose/unexpose Partially fixes #1246983 https://code.launchpad.net/~axwalk/juju-core/lp1246983-cli-api-exposeunexpose/+merge/193562 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : cmd/juju: use API for expose/unexpose #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+111 lines, -226 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/juju/expose.go	View		2 chunks	+3 lines, -9 lines	0 comments	Download
M	cmd/juju/unexpose.go	View		2 chunks	+3 lines, -6 lines	0 comments	Download
M	state/apiserver/client/client.go	View		1 chunk	+10 lines, -2 lines	0 comments	Download
M	state/apiserver/client/client_test.go	View	1	1 chunk	+93 lines, -20 lines	0 comments	Download
D	state/statecmd/expose.go	View		1 chunk	+0 lines, -22 lines	0 comments	Download
D	state/statecmd/expose_test.go	View		1 chunk	+0 lines, -77 lines	0 comments	Download
D	state/statecmd/unexpose.go	View		1 chunk	+0 lines, -22 lines	0 comments	Download
D	state/statecmd/unexpose_test.go	View		1 chunk	+0 lines, -68 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

john2

almost there. You cleaned up statecmd and you're using the API, but it feels like ...

10 years, 5 months ago (2013-11-02 20:25:49 UTC) #2

LGTM

Expand All Messages | Collapse All Messages