Issue 183091: code review 183091: Allow slice values in binary.Write. Fixes issue 478

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 183091: code review 183091: Allow slice values in binary.Write. Fixes issue 478

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by hoisie

Modified:
4 years, 6 months ago

Reviewers:
golang-dev+timeout

Visibility:
Public.

Description

Allow slice values in binary.Write. Fixes issue 478

Patch Set 2 : code review 183091: Allow slice values in binary.Write. Fixes issue 478 #

Total comments: 1

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -27 lines)			Patch
	M	src/pkg/encoding/binary/binary.go	View		4 chunks	+32 lines, -27 lines	1 comment	Download
	M	src/pkg/encoding/binary/binary_test.go	View		1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

hoisie

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review the following change.

14 years, 3 months ago (2009-12-30 05:04:23 UTC) #1

rsc

http://codereview.appspot.com/183091/diff/6/1001 File src/pkg/encoding/binary/binary.go (right): http://codereview.appspot.com/183091/diff/6/1001#newcode182 src/pkg/encoding/binary/binary.go:182: case *reflect.SliceValue: This isn't right. It allows slice values ...

14 years, 3 months ago (2010-01-05 22:36:15 UTC) #3

Expand All Messages | Collapse All Messages