Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(51)

Issue 183091: code review 183091: Allow slice values in binary.Write. Fixes issue 478

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by hoisie
Modified:
4 weeks ago
Reviewers:
golang-dev+timeout
Visibility:
Public.

Description

Allow slice values in binary.Write. Fixes issue 478

Patch Set 1 #

Patch Set 2 : code review 183091: Allow slice values in binary.Write. Fixes issue 478 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -27 lines) Patch
M src/pkg/encoding/binary/binary.go View 4 chunks +32 lines, -27 lines 1 comment Download
M src/pkg/encoding/binary/binary_test.go View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 4
hoisie
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review the following change.
9 years, 10 months ago (2009-12-30 05:04:23 UTC) #1
r
9 years, 10 months ago (2010-01-04 00:04:11 UTC) #2
rsc
http://codereview.appspot.com/183091/diff/6/1001 File src/pkg/encoding/binary/binary.go (right): http://codereview.appspot.com/183091/diff/6/1001#newcode182 src/pkg/encoding/binary/binary.go:182: case *reflect.SliceValue: This isn't right. It allows slice values ...
9 years, 10 months ago (2010-01-05 22:36:15 UTC) #3
rsc
9 years, 10 months ago (2010-01-15 22:02:04 UTC) #4

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b