Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2876)

Issue 182560043: [release-branch.go1.4] code review 182560043: api: create go1.4.txt

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 10 months ago by rsc
Modified:
6 years, 10 months ago
Reviewers:
brainman, adg1, adg, bradfitz
CC:
r, minux, bradfitz, adg1, adg, golang-codereviews, gri, iant
Visibility:
Public.

Description

api: create go1.4.txt I read through and vetted these but others should look too.

Patch Set 1 #

Patch Set 2 : diff -r eec5db5083b7621548dabe7c9f2df57f37e8e128 https://code.google.com/p/go/ #

Patch Set 3 : diff -r eec5db5083b7621548dabe7c9f2df57f37e8e128 https://code.google.com/p/go/ #

Patch Set 4 : diff -r b5c6a4abeb4cdb46c7c5824ffb14fa1697a0b82d https://code.google.com/p/go/ #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+607 lines, -143 lines) Patch
A api/go1.4.txt View 1 2 3 1 chunk +604 lines, -0 lines 2 comments Download
M api/next.txt View 1 1 chunk +0 lines, -141 lines 0 comments Download
M src/cmd/api/run.go View 1 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 14
rsc
Hello r (cc: adg, bradfitz, golang-codereviews@googlegroups.com, gri, iant), I'd like you to review this change ...
6 years, 10 months ago (2014-12-05 21:18:12 UTC) #1
bradfitz
I just read it. One inconsistency that is kinda weird: +# CL 122960043 encoding/xml: add ...
6 years, 10 months ago (2014-12-05 21:51:17 UTC) #2
bradfitz
Oh, and as highlighted but not mentioned: the xml package isn't even internally consistent, naming ...
6 years, 10 months ago (2014-12-05 21:53:31 UTC) #3
rsc
I'll change Byte -> Offset. Thanks.
6 years, 10 months ago (2014-12-05 21:54:00 UTC) #4
minux
https://codereview.appspot.com/182560043/diff/60001/api/go1.4.txt File api/go1.4.txt (right): https://codereview.appspot.com/182560043/diff/60001/api/go1.4.txt#newcode476 api/go1.4.txt:476: pkg syscall (windows-386), func LoadCreateSymbolicLink() error Why is this ...
6 years, 10 months ago (2014-12-07 02:25:37 UTC) #5
bradfitz
LGTM
6 years, 10 months ago (2014-12-07 23:58:26 UTC) #6
adg1
LGTM
6 years, 10 months ago (2014-12-08 00:05:10 UTC) #7
adg1
I'll submit this shortly.
6 years, 10 months ago (2014-12-08 00:06:33 UTC) #8
adg
No, I won't.​
6 years, 10 months ago (2014-12-08 00:30:20 UTC) #9
rsc
https://codereview.appspot.com/182560043/diff/60001/api/go1.4.txt File api/go1.4.txt (right): https://codereview.appspot.com/182560043/diff/60001/api/go1.4.txt#newcode476 api/go1.4.txt:476: pkg syscall (windows-386), func LoadCreateSymbolicLink() error On 2014/12/07 02:25:37, ...
6 years, 10 months ago (2014-12-10 00:06:10 UTC) #10
adg
*** Submitted as https://code.google.com/p/go/source/detail?r=82920819eae8 *** [release-branch.go1.4] api: create go1.4.txt I read through and vetted these ...
6 years, 10 months ago (2014-12-10 00:07:49 UTC) #11
brainman
On 2014/12/07 02:25:37, minux wrote: > api/go1.4.txt:476: pkg syscall (windows-386), func LoadCreateSymbolicLink() > error > ...
6 years, 10 months ago (2014-12-10 03:19:57 UTC) #12
minux
On Tue, Dec 9, 2014 at 10:19 PM, <alex.brainman@gmail.com> wrote: > ... Why not just ...
6 years, 10 months ago (2014-12-10 03:28:55 UTC) #13
minux
6 years, 10 months ago (2014-12-10 03:35:01 UTC) #14
On Tue, Dec 9, 2014 at 10:28 PM, minux <minux@golang.org> wrote:
>
> Or put it another way, should we introduce LoadXXX for every function XXXX
> that
> we want to use but might not be available on every version of windows?
>
OK. It seems syscall package for windows has already established the
convention
that for every function that is not universally available, add a Load
function for that.

I should have complained much earlier. That's not how the syscall package
for other
systems works. (they will return ENOSYS if the syscall doesn't exist. And
only getwd
is special cased to have an ImplementsGetwd const.)

I withdraw my objection.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b