Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(520)

Issue 181560043: ComputeCredential (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years ago by peleyal
Modified:
5 years ago
Reviewers:
srashid, class
CC:
google-api-dotnet-client_google.com
Base URL:
https://google-api-dotnet-client.googlecode.com/hg/
Visibility:
Public.

Description

Implementation for ComputeCredential. srashid@ already tested that it works. TODO(peleyal): Verify the our G+ sample works with the changed to ServiceAccountCredential.

Patch Set 1 #

Patch Set 2 : comments #

Patch Set 3 : minor #

Total comments: 16

Patch Set 4 : minor #

Patch Set 5 : minor minor #

Patch Set 6 : reverting changes to Program release #

Unified diffs Side-by-side diffs Delta from patch set Stats (+307 lines, -136 lines) Patch
M Src/GoogleApis.Auth.DotNet4/OAuth2/ServiceAccountCredential.cs View 1 9 chunks +9 lines, -135 lines 0 comments Download
M Src/GoogleApis.Auth/GoogleApis.Auth.csproj View 1 chunk +2 lines, -0 lines 0 comments Download
A Src/GoogleApis.Auth/OAuth2/ComputeCredential.cs View 1 2 3 4 1 chunk +86 lines, -0 lines 0 comments Download
M Src/GoogleApis.Auth/OAuth2/GoogleConsts.cs View 1 chunk +5 lines, -1 line 0 comments Download
A Src/GoogleApis.Auth/OAuth2/ServiceCredential.cs View 1 2 3 1 chunk +205 lines, -0 lines 0 comments Download

Messages

Total messages: 5
peleyal
Hi, Note: Most of the content of ComputeCredential was copied from ServiceAccountCredential because it is ...
5 years ago (2014-12-11 15:54:50 UTC) #1
class
A few nits and comment change suggestions https://codereview.appspot.com/181560043/diff/40001/Src/GoogleApis.Auth/OAuth2/ComputeCredential.cs File Src/GoogleApis.Auth/OAuth2/ComputeCredential.cs (right): https://codereview.appspot.com/181560043/diff/40001/Src/GoogleApis.Auth/OAuth2/ComputeCredential.cs#newcode55 Src/GoogleApis.Auth/OAuth2/ComputeCredential.cs:55: : this(new ...
5 years ago (2014-12-11 18:39:11 UTC) #2
peleyal
https://codereview.appspot.com/181560043/diff/40001/Src/GoogleApis.Auth/OAuth2/ComputeCredential.cs File Src/GoogleApis.Auth/OAuth2/ComputeCredential.cs (right): https://codereview.appspot.com/181560043/diff/40001/Src/GoogleApis.Auth/OAuth2/ComputeCredential.cs#newcode55 Src/GoogleApis.Auth/OAuth2/ComputeCredential.cs:55: : this(new Initializer()) { } On 2014/12/11 18:39:10, class ...
5 years ago (2014-12-12 23:13:29 UTC) #3
class
LGTM, optionally remove the extra newlines on the initializers passed in to the ComputeCredential constructors. ...
5 years ago (2014-12-12 23:27:57 UTC) #4
peleyal
5 years ago (2014-12-12 23:34:58 UTC) #5
pushing now :)

https://codereview.appspot.com/181560043/diff/40001/Src/GoogleApis.Auth/OAuth...
File Src/GoogleApis.Auth/OAuth2/ComputeCredential.cs (right):

https://codereview.appspot.com/181560043/diff/40001/Src/GoogleApis.Auth/OAuth...
Src/GoogleApis.Auth/OAuth2/ComputeCredential.cs:55: : this(new Initializer()) {
}
On 2014/12/12 23:27:57, class wrote:
> On 2014/12/12 23:13:29, peleyal wrote:
> > On 2014/12/11 18:39:10, class wrote:
> > > Is there a reason you added the newline before ' : ' operator here and
> below?
> > > You should be able to put this on the previous line
> > 
> > That's what happened when I used the default formatter.
> > Do you think I should change it?
> > 
> > It doesn't really important to me - so whatever you decided :)
> 
> I don't feel too strongly but : on the same line seems cleaner...

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b