Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(800)

Issue 179910043: i#1551 Port DynamoRIO to ARM: add empty functions in arm.asm for ARM build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 4 months ago by zhaoqin
Modified:
9 years, 4 months ago
Reviewers:
bruening
CC:
dynamorio-devs_googlegroups.com
Base URL:
https://dynamorio.googlecode.com/svn/trunk
Visibility:
Public.

Description

i#1551 Port DynamoRIO to ARM: add empty functions in arm.asm for ARM build - add empty functions in arm.asm to for ARM build - update os.c for ARM build R=bruening@google.com BUG=1551 Committed: https://code.google.com/p/dynamorio/source/detail?r=3005

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -14 lines) Patch
M core/arch/arm/arm.asm View 2 chunks +139 lines, -5 lines 3 comments Download
M core/arch/x86/x86.asm View 1 chunk +1 line, -1 line 0 comments Download
M core/unix/os.c View 8 chunks +31 lines, -8 lines 0 comments Download

Messages

Total messages: 3
zhaoqin
9 years, 4 months ago (2014-11-18 22:07:27 UTC) #1
bruening
LGTM if the NYI asm routines all have asserts added https://codereview.appspot.com/179910043/diff/1/core/arch/arm/arm.asm File core/arch/arm/arm.asm (right): https://codereview.appspot.com/179910043/diff/1/core/arch/arm/arm.asm#newcode123 ...
9 years, 4 months ago (2014-11-19 04:59:45 UTC) #2
zhaoqin
9 years, 4 months ago (2014-11-19 23:40:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 3005 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b