Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(248)

Issue 179830043: code review 179830043: [release-branch.go1.4] remove cmd/link from nacl test zip (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years ago by adg
Modified:
8 years ago
Reviewers:
dsymonds
CC:
rsc, dsymonds, golang-codereviews
Visibility:
Public.

Description

[release-branch.go1.4] remove cmd/link from nacl test zip

Patch Set 1 #

Patch Set 2 : diff -r 0e2181d86f0b60e35254e0900d46154137147a9a https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M misc/nacl/testzip.proto View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4
adg
Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
8 years ago (2014-11-17 02:54:36 UTC) #1
dsymonds
LGTM hah, you beat me to it.
8 years ago (2014-11-17 02:55:14 UTC) #2
dsymonds
I was also going to suggest removing it from the default branch too, since it ...
8 years ago (2014-11-17 02:55:54 UTC) #3
adg
8 years ago (2014-11-17 02:56:08 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=bffdd0cae380 ***

[release-branch.go1.4] remove cmd/link from nacl test zip

LGTM=dsymonds
R=rsc, dsymonds
CC=golang-codereviews
https://codereview.appspot.com/179830043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b