Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(264)

Side by Side Diff: dashboard/app/build/notify.go

Issue 179820043: code review 179820043: x/tools/dashboard/app: ignore freebsd-arm failures (Closed)
Patch Set: diff -r 891c383e4b72aaedb55a165cfaa4d4fbb0881bdf https://code.google.com/p/go.tools Created 9 years, 4 months ago
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 The Go Authors. All rights reserved. 1 // Copyright 2011 The Go Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style 2 // Use of this source code is governed by a BSD-style
3 // license that can be found in the LICENSE file. 3 // license that can be found in the LICENSE file.
4 4
5 // +build appengine 5 // +build appengine
6 6
7 package build 7 package build
8 8
9 import ( 9 import (
10 "bytes" 10 "bytes"
(...skipping 20 matching lines...) Expand all
31 failMailTo = "golang-dev@googlegroups.com" 31 failMailTo = "golang-dev@googlegroups.com"
32 domain = "build.golang.org" 32 domain = "build.golang.org"
33 gobotBase = "http://research.swtch.com/gobot_codereview" 33 gobotBase = "http://research.swtch.com/gobot_codereview"
34 ) 34 )
35 35
36 // ignoreFailure is a set of builders that we don't email about because 36 // ignoreFailure is a set of builders that we don't email about because
37 // they are not yet production-ready. 37 // they are not yet production-ready.
38 var ignoreFailure = map[string]bool{ 38 var ignoreFailure = map[string]bool{
39 "dragonfly-386": true, 39 "dragonfly-386": true,
40 "dragonfly-amd64": true, 40 "dragonfly-amd64": true,
41 "freebsd-arm": true,
41 "netbsd-amd64-bsiegert": true, 42 "netbsd-amd64-bsiegert": true,
42 "netbsd-arm-rpi": true, 43 "netbsd-arm-rpi": true,
43 "plan9-amd64-aram": true, 44 "plan9-amd64-aram": true,
44 } 45 }
45 46
46 // notifyOnFailure checks whether the supplied Commit or the subsequent 47 // notifyOnFailure checks whether the supplied Commit or the subsequent
47 // Commit (if present) breaks the build for this builder. 48 // Commit (if present) breaks the build for this builder.
48 // If either of those commits break the build an email notification is sent 49 // If either of those commits break the build an email notification is sent
49 // from a delayed task. (We use a task because this way the mail won't be 50 // from a delayed task. (We use a task because this way the mail won't be
50 // sent if the enclosing datastore transaction fails.) 51 // sent if the enclosing datastore transaction fails.)
(...skipping 317 matching lines...) Expand 10 before | Expand all | Expand 10 after
368 ReplyTo: failMailTo, 369 ReplyTo: failMailTo,
369 Subject: subject, 370 Subject: subject,
370 Body: body.String(), 371 Body: body.String(),
371 } 372 }
372 373
373 // send mail 374 // send mail
374 if err := mail.Send(c, msg); err != nil { 375 if err := mail.Send(c, msg); err != nil {
375 c.Errorf("sending mail: %v", err) 376 c.Errorf("sending mail: %v", err)
376 } 377 }
377 } 378 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b