Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(122)

Issue 177041: Client doc review (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by yangoon1
Modified:
10 years, 10 months ago
Reviewers:
bch, paepke, udono, ced1
Visibility:
Public.

Patch Set 1 #

Total comments: 6

Patch Set 2 : Include proposals #

Total comments: 1

Patch Set 3 : Fixes for Email dialog #

Total comments: 1

Patch Set 4 : Path in italics #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -77 lines) Patch
M doc/usage.rst View 1 2 3 30 chunks +78 lines, -77 lines 0 comments Download

Messages

Total messages: 9
udono
Good job. Have some issues to discuss... Cheers Udo http://codereview.appspot.com/177041/diff/1/2 File doc/usage.rst (right): http://codereview.appspot.com/177041/diff/1/2#newcode86 doc/usage.rst:86: ...
10 years, 10 months ago (2009-12-14 19:06:19 UTC) #1
ced1
http://codereview.appspot.com/177041/diff/1/2 File doc/usage.rst (right): http://codereview.appspot.com/177041/diff/1/2#newcode835 doc/usage.rst:835: Open a dialog to set up a mail reader ...
10 years, 10 months ago (2009-12-14 22:51:02 UTC) #2
yangoon1
Proposals included.
10 years, 10 months ago (2009-12-15 12:11:47 UTC) #3
ced1
http://codereview.appspot.com/177041/diff/2002/2003 File doc/usage.rst (right): http://codereview.appspot.com/177041/diff/2002/2003#newcode835 doc/usage.rst:835: Open a dialog to set up an email reader. ...
10 years, 10 months ago (2009-12-15 12:15:18 UTC) #4
paepke
http://codereview.appspot.com/177041/diff/1/2 File doc/usage.rst (right): http://codereview.appspot.com/177041/diff/1/2#newcode86 doc/usage.rst:86: Status bar |realname company Waiting requests... user@... | On ...
10 years, 10 months ago (2009-12-15 12:57:36 UTC) #5
yangoon1
On 2009/12/15 12:57:36, paepke wrote: > http://codereview.appspot.com/177041/diff/1/2 > File doc/usage.rst (right): > > http://codereview.appspot.com/177041/diff/1/2#newcode86 > ...
10 years, 10 months ago (2009-12-15 14:48:44 UTC) #6
yangoon1
10 years, 10 months ago (2009-12-15 22:05:32 UTC) #7
udono
all ok, but one small issue. http://codereview.appspot.com/177041/diff/4001/3006 File doc/usage.rst (right): http://codereview.appspot.com/177041/diff/4001/3006#newcode855 doc/usage.rst:855: would use italics ...
10 years, 10 months ago (2009-12-15 23:26:47 UTC) #8
yangoon1
10 years, 10 months ago (2009-12-16 17:24:29 UTC) #9

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b