Side by Side Diff: 2014/readability/if-switch-bad.go
Issue 176660043 :
code review 176660043: x/talks/2014/readability: talk for GoCon 2014 autumn in...
Patch Set: diff -r 05bdda42259e https://code.google.com/p/go.talks/
Use n/p to move between diff chunks;
N/P to move between comments.
Please Sign in to add in-line comments.
Jump to:
2014/readability.slide
2014/readability/close-cond-bad.go
2014/readability/close-cond-good.go
2014/readability/err_close_write_bad.go
2014/readability/err_close_write_good.go
2014/readability/err_regexp_bad.go
2014/readability/err_regexp_good.go
2014/readability/example_test.go
2014/readability/gopher-ok-no.png
2014/readability/gophers5th.jpg
2014/readability/if-else-bad.go
2014/readability/if-else-good.go
2014/readability/if-switch-bad.go
2014/readability/if-switch-good.go
2014/readability/implement-interface-bad.go
2014/readability/implement-interface-good.go
2014/readability/in-band-error.go
2014/readability/in-band-error-client.go
2014/readability/long-line-fold.go
2014/readability/long-line-nofold.go
2014/readability/long-line-short.go
2014/readability/nil_error.go
2014/readability/nil_interface_en.go
2014/readability/pkg.png
2014/readability/project.png
2014/readability/ref.png
2014/readability/reflect-bad.go
2014/readability/reflect-good.go
2014/readability/resthandler.go
2014/readability/resthandler-fix2.go
2014/readability/struct-field-bad.go
2014/readability/struct-field-good.go
2014/readability/talks.png
2014/readability/test-pattern_en.go
2014/readability/time_duration_bad.go
2014/readability/time_duration_bad1.go
2014/readability/time_duration_bad2.go
2014/readability/time_duration_good.go
2014/readability/val-and-error.go
OLD NEW
(Empty) 1 package sample // OMIT
2
3 func BrowserHeightBucket(s *session.Event) string {
4 browserSize := sizeFromSession(s)
5 if h := browserSize.GetHeight(); h > 0 { // HL
6 browserHeight := int(h)
7 if browserHeight <= 480 { // HL
8 return "small"
9 } else if browserHeight <= 640 { // HL
10 return "medium"
11 } else {
12 return "large"
13 }
14 } else {
15 return "null"
16 }
17 }
OLD NEW