Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1776)

Issue 176660043: code review 176660043: x/talks/2014/readability: talk for GoCon 2014 autumn in...

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 3 months ago by ukai
Modified:
6 years, 3 months ago
Reviewers:
r, adg, minux
CC:
r, golang-codereviews
Visibility:
Public.

Description

x/talks/2014/readability: talk for GoCon 2014 autumn in Tokyo

Patch Set 1 #

Patch Set 2 : diff -r 05bdda42259e https://code.google.com/p/go.talks/ #

Patch Set 3 : diff -r 05bdda42259e https://code.google.com/p/go.talks/ #

Patch Set 4 : diff -r 05bdda42259e https://code.google.com/p/go.talks/ #

Patch Set 5 : diff -r 05bdda42259e https://code.google.com/p/go.talks/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+830 lines, -0 lines) Patch
A 2014/readability.slide View 1 chunk +388 lines, -0 lines 0 comments Download
A 2014/readability/close-cond-bad.go View 1 chunk +26 lines, -0 lines 0 comments Download
A 2014/readability/close-cond-good.go View 1 chunk +22 lines, -0 lines 0 comments Download
A 2014/readability/err_close_write_bad.go View 1 chunk +16 lines, -0 lines 0 comments Download
A 2014/readability/err_close_write_good.go View 1 chunk +20 lines, -0 lines 0 comments Download
A 2014/readability/err_regexp_bad.go View 1 chunk +5 lines, -0 lines 0 comments Download
A 2014/readability/err_regexp_good.go View 1 chunk +5 lines, -0 lines 0 comments Download
A 2014/readability/example_test.go View 1 chunk +12 lines, -0 lines 0 comments Download
A 2014/readability/gopher-ok-no.png View Binary file 0 comments Download
A 2014/readability/gophers5th.jpg View Binary file 0 comments Download
A 2014/readability/if-else-bad.go View 1 chunk +11 lines, -0 lines 0 comments Download
A 2014/readability/if-else-good.go View 1 chunk +11 lines, -0 lines 0 comments Download
A 2014/readability/if-switch-bad.go View 1 chunk +17 lines, -0 lines 0 comments Download
A 2014/readability/if-switch-good.go View 1 chunk +16 lines, -0 lines 0 comments Download
A 2014/readability/implement-interface-bad.go View 1 chunk +10 lines, -0 lines 0 comments Download
A 2014/readability/implement-interface-good.go View 1 chunk +11 lines, -0 lines 0 comments Download
A 2014/readability/in-band-error.go View 1 chunk +21 lines, -0 lines 0 comments Download
A 2014/readability/in-band-error-client.go View 1 chunk +11 lines, -0 lines 0 comments Download
A 2014/readability/long-line-fold.go View 1 chunk +15 lines, -0 lines 0 comments Download
A 2014/readability/long-line-nofold.go View 1 chunk +13 lines, -0 lines 0 comments Download
A 2014/readability/long-line-short.go View 1 chunk +13 lines, -0 lines 0 comments Download
A 2014/readability/nil_error.go View 1 chunk +18 lines, -0 lines 0 comments Download
A 2014/readability/nil_interface_en.go View 1 chunk +16 lines, -0 lines 0 comments Download
A 2014/readability/pkg.png View Binary file 0 comments Download
A 2014/readability/project.png View Binary file 0 comments Download
A 2014/readability/ref.png View Binary file 0 comments Download
A 2014/readability/reflect-bad.go View 1 chunk +20 lines, -0 lines 0 comments Download
A 2014/readability/reflect-good.go View 1 chunk +24 lines, -0 lines 0 comments Download
A 2014/readability/resthandler.go View 1 chunk +21 lines, -0 lines 0 comments Download
A 2014/readability/resthandler-fix2.go View 1 chunk +20 lines, -0 lines 0 comments Download
A 2014/readability/struct-field-bad.go View 1 chunk +8 lines, -0 lines 0 comments Download
A 2014/readability/struct-field-good.go View 1 chunk +9 lines, -0 lines 0 comments Download
A 2014/readability/talks.png View Binary file 0 comments Download
A 2014/readability/test-pattern_en.go View 1 chunk +8 lines, -0 lines 0 comments Download
A 2014/readability/time_duration_bad.go View 1 chunk +3 lines, -0 lines 0 comments Download
A 2014/readability/time_duration_bad1.go View 1 chunk +5 lines, -0 lines 0 comments Download
A 2014/readability/time_duration_bad2.go View 1 chunk +5 lines, -0 lines 0 comments Download
A 2014/readability/time_duration_good.go View 1 chunk +5 lines, -0 lines 0 comments Download
A 2014/readability/val-and-error.go View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 5
ukai
Hello r@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.talks/
6 years, 3 months ago (2014-12-03 01:37:21 UTC) #1
r
LGTM i will submit
6 years, 3 months ago (2014-12-03 01:40:03 UTC) #2
ukai
On 2014/12/03 01:40:03, r wrote: > LGTM > i will submit thanks!
6 years, 3 months ago (2014-12-03 01:51:19 UTC) #3
adg
*** Submitted as https://code.google.com/p/go/source/detail?r=38cc85636e1f&repo=talks *** x/talks/2014/readability: talk for GoCon 2014 autumn in Tokyo LGTM=r R=r ...
6 years, 3 months ago (2014-12-03 01:51:28 UTC) #4
minux
6 years, 3 months ago (2014-12-05 02:23:03 UTC) #5
It seems all the png image files are missing in the repo but are present in
this CL.

I also find some other small cosmetic problems in the slides. will send a
CL.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b