Issue 176180043: Issue 4204: Convert ly::time-signature::print from C++ to Scheme.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 176180043: Issue 4204: Convert ly::time-signature::print from C++ to Scheme. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 5 months ago by Dan Eble

Modified:
9 years, 4 months ago

Reviewers:
Keith

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Issue 4204: Convert ly::time-signature::print from C++ to Scheme. The user may add a new time signature style by calling add-simple-time-signature-style and providing a procedure returning markup.

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 2

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+120 lines, -212 lines)			Patch
M	input/regression/time-signature-mensural.ly	View	1 chunk	+4 lines, -4 lines	0 comments	Download
A	input/regression/time-signature-user-defined.ly	View	1 chunk	+22 lines, -0 lines	2 comments	Download
D	lily/include/time-signature.hh	View	1 chunk	+0 lines, -41 lines	0 comments	Download
M	lily/slur-scoring.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
D	lily/time-signature.cc	View	1 chunk	+0 lines, -164 lines	0 comments	Download
M	lily/time-signature-engraver.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	scm/define-grob-interfaces.scm	View	1 chunk	+18 lines, -0 lines	0 comments	Download
M	scm/lily.scm	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	scm/time-signature.scm	View	1 chunk	+35 lines, -0 lines	0 comments	Download
M	scm/time-signature-settings.scm	View	1 chunk	+39 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Keith

9 years, 4 months ago (2014-12-08 06:30:23 UTC) #3

Looks good.
Having the built-in time signature markup in Scheme, available as
building-blocks for custom time signatures, will probably be useful for several
people.
You might just leave out the regression test.

https://codereview.appspot.com/176180043/diff/20001/input/regression/time-sig...
File input/regression/time-signature-user-defined.ly (right):

https://codereview.appspot.com/176180043/diff/20001/input/regression/time-sig...
input/regression/time-signature-user-defined.ly:7:
#(add-simple-time-signature-style 'topsy-turvy
Normal use of TimeSignature tests add-simple-time-signature, so we don't really
need another regression test to look at every time a new version comes out.
This is more documentation than test.  If you can put this in the LSR as a
documentation snippet, then later you could just remove this regression test.

https://codereview.appspot.com/176180043/diff/20001/input/regression/time-sig...
input/regression/time-signature-user-defined.ly:16: \override
Score.TimeSignature.style = #'topsy-turvy
At first I didn't like making an example of overriding the 'style, when we can
already override the 'stencil, and learning to override the stencil is more
general (using grob-interpret-markup instead of learning how
add-simple-time-signature works) but I got over it.

Expand All Messages | Collapse All Messages