Issue 175390043: i#1512: mark startstop flaky

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 175390043: i#1512: mark startstop flaky (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 5 months ago by zhaoqin

Modified:
9 years, 5 months ago

Reviewers:
bruening

CC:
dynamorio-devs_googlegroups.com

Base URL:
https://dynamorio.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

i#1512: mark startstop flaky R=bruening@google.com BUG=1512 Committed: https://code.google.com/p/dynamorio/source/detail?r=3008

Patch Set 1 #

Total comments: 1

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	suite/tests/CMakeLists.txt	View		2 chunks	+4 lines, -3 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bruening

LGTM https://codereview.appspot.com/175390043/diff/1/suite/tests/CMakeLists.txt File suite/tests/CMakeLists.txt (right): https://codereview.appspot.com/175390043/diff/1/suite/tests/CMakeLists.txt#newcode559 suite/tests/CMakeLists.txt:559: endif ("${test}" MATCHES "^pthread|startstop_FLAKY") I would suggest just ...

9 years, 5 months ago (2014-11-20 03:03:34 UTC) #2

zhaoqin

9 years, 5 months ago (2014-11-20 17:10:02 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 3008 (presubmit successful).

Expand All Messages | Collapse All Messages