Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1461)

Issue 175180043: i#1551 Port DynamoRIO to ARM: update emit_utils to build on ARM (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by zhaoqin
Modified:
4 years, 9 months ago
Reviewers:
bruening
CC:
dynamorio-devs_googlegroups.com
Base URL:
https://dynamorio.googlecode.com/svn/trunk
Visibility:
Public.

Description

i#1551 Port DynamoRIO to ARM: update emit_utils to build on ARM - move x86-specific code into x86/emit_utils.c BUG=1551 R=bruening@google.com Committed: https://code.google.com/p/dynamorio/source/detail?r=3004

Patch Set 1 #

Patch Set 2 : PTL #

Patch Set 3 : #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+3366 lines, -2914 lines) Patch
M core/arch/arch.h View 1 3 chunks +126 lines, -9 lines 1 comment Download
M core/arch/arch.c View 1 2 2 chunks +2 lines, -0 lines 1 comment Download
M core/arch/arm/emit_utils.c View 1 2 2 chunks +194 lines, -0 lines 1 comment Download
M core/arch/arm/instr_create.h View 1 chunk +6 lines, -0 lines 3 comments Download
M core/arch/emit_utils_shared.c View 1 112 chunks +581 lines, -2905 lines 0 comments Download
M core/arch/interp.c View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M core/arch/x86/emit_utils.c View 1 2 chunks +2455 lines, -0 lines 0 comments Download

Messages

Total messages: 3
zhaoqin
Please take a look
4 years, 9 months ago (2014-11-17 21:51:10 UTC) #1
bruening
LGTM if the arm INSTR_CREATE_ are changed to XINST_CREATE_ cross-platform macros https://codereview.appspot.com/175180043/diff/40001/core/arch/arch.c File core/arch/arch.c (right): ...
4 years, 9 months ago (2014-11-19 05:09:36 UTC) #2
zhaoqin
4 years, 9 months ago (2014-11-19 23:14:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 3004 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b