Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(834)

Issue 17500043: cloudinit: Use cloud archive key not short key id

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by gz
Modified:
10 years, 5 months ago
Reviewers:
mp+192769, john2
Visibility:
Public.

Description

cloudinit: Use cloud archive key not short key id Cherrypick of r2002 from trunk. Currently, when adding the cloud archive to apt_sources for precise, we supply the short key id to obtain the signing key. However, this requires access to the keyserver, which not all deployments will have. By supplying the full text of the public key instead, we can verify the download without needing additional access. https://code.launchpad.net/~gz/juju-core/1.16_cloud_archive_key/+merge/192769 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -40 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M cloudinit/cloudinit.go View 1 chunk +3 lines, -5 lines 0 comments Download
M cloudinit/cloudinit_test.go View 1 chunk +0 lines, -7 lines 0 comments Download
M cloudinit/options.go View 1 chunk +0 lines, -13 lines 0 comments Download
M environs/cloudinit/cloudinit.go View 2 chunks +50 lines, -3 lines 0 comments Download
M environs/cloudinit/cloudinit_test.go View 3 chunks +7 lines, -12 lines 0 comments Download

Messages

Total messages: 2
gz
Please take a look.
10 years, 5 months ago (2013-10-26 00:49:45 UTC) #1
john2
10 years, 5 months ago (2013-10-28 09:36:56 UTC) #2
LGTM

Is there a bug that you can link this against, to make sure we are aware of the
backport to the 1.16 series?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b