Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(56)

Issue 1740043: code review 1740043: math: amd64 version of log (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 5 months ago by Charlie Dorian
Modified:
5 days, 21 hours ago
Reviewers:
rsc
CC:
rsc, golang-dev
Visibility:
Public.

Description

math: amd64 version of log Benchmarks 25ns/op (was 58ns/op) on 2.53GHz Intel Core 2 Duo.

Patch Set 1 #

Patch Set 2 : code review 1740043: math: amd64 version of log #

Patch Set 3 : code review 1740043: math: amd64 version of log #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -27 lines) Patch
M src/pkg/math/Makefile View 3 chunks +4 lines, -1 line 0 comments Download
M src/pkg/math/log.go View 1 chunk +0 lines, -8 lines 0 comments Download
A src/pkg/math/log10.go View 1 chunk +13 lines, -0 lines 0 comments Download
A src/pkg/math/log10_386.s View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
A src/pkg/math/log10_decl.go View 1 chunk +8 lines, -0 lines 0 comments Download
M src/pkg/math/log_386.s View 1 2 1 chunk +0 lines, -16 lines 0 comments Download
A src/pkg/math/log_amd64.s View 1 2 1 chunk +109 lines, -0 lines 0 comments Download
M src/pkg/math/log_decl.go View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4
Charlie Dorian
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
8 years, 5 months ago (2010-07-02 17:38:44 UTC) #1
Charlie Dorian
Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.
8 years, 5 months ago (2010-07-06 04:25:10 UTC) #2
rsc
LGTM
8 years, 5 months ago (2010-07-12 18:29:58 UTC) #3
rsc
8 years, 5 months ago (2010-07-12 18:30:18 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=cfb8de3a280b ***

math: amd64 version of log

Benchmarks 25ns/op (was 58ns/op) on 2.53GHz Intel Core 2 Duo.

R=rsc
CC=golang-dev
http://codereview.appspot.com/1740043

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b