Issue 1740043: code review 1740043: math: amd64 version of log

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1740043: code review 1740043: math: amd64 version of log (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by Charlie Dorian

Modified:
5 years, 4 months ago

Reviewers:
rsc

CC:
rsc, golang-dev

Visibility:
Public.

Description

math: amd64 version of log Benchmarks 25ns/op (was 58ns/op) on 2.53GHz Intel Core 2 Duo.

Patch Set 1 #

Patch Set 2 : code review 1740043: math: amd64 version of log #

Patch Set 3 : code review 1740043: math: amd64 version of log #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+153 lines, -27 lines)			Patch
M	src/pkg/math/Makefile	View		3 chunks	+4 lines, -1 line	0 comments	Download
M	src/pkg/math/log.go	View		1 chunk	+0 lines, -8 lines	0 comments	Download
A	src/pkg/math/log10.go	View		1 chunk	+13 lines, -0 lines	0 comments	Download
A	src/pkg/math/log10_386.s	View	1 2	1 chunk	+19 lines, -0 lines	0 comments	Download
A	src/pkg/math/log10_decl.go	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/pkg/math/log_386.s	View	1 2	1 chunk	+0 lines, -16 lines	0 comments	Download
A	src/pkg/math/log_amd64.s	View	1 2	1 chunk	+109 lines, -0 lines	0 comments	Download
M	src/pkg/math/log_decl.go	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Charlie Dorian

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

13 years, 9 months ago (2010-07-02 17:38:44 UTC) #1

Charlie Dorian

Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 9 months ago (2010-07-06 04:25:10 UTC) #2

rsc

13 years, 9 months ago (2010-07-12 18:30:18 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=cfb8de3a280b ***

math: amd64 version of log

Benchmarks 25ns/op (was 58ns/op) on 2.53GHz Intel Core 2 Duo.

R=rsc
CC=golang-dev
http://codereview.appspot.com/1740043

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages