Fix trill timing in articulate.ly

Fix trill timing in articulate.ly

Used a fixed duration for the "twiddletime" instead of the broken heuristic
that was used before.

[Dan Eble, 2014-11-07 13:11:02]

It's a bit presumptuous of me to comment on code I know little about, but it
occurs to me that if it were that simple, it probably would have been done that
way in the first place.

Can you go into some detail about the nature of the problem?  What case was
failing for you and how is your version better?

Are the existing regression tests thorough enough to fail if you have
oversimplified something?  Do you need to write a new regression test so that
your case which was handled badly in the past does not break again the next time
someone modifies this code?

[peter.chubb_nicta.com.au, 2014-11-09 23:31:28]

>>>>>   <nine.fierce.ballads@gmail.com> writes:

> It's a bit presumptuous of me to comment on code I know little
> about, but it occurs to me that if it were that simple, it probably
> would have been done that way in the first place.

I wrote the original --- I hadn't thought that it would be this
simple!

The heuristics to choose the twiddletime in my code worked sometimes.
But often, (especially noticeable in slow passages) the trills sounded
too slow.  Try Messiaen's `Abime des Oiseaux' for instance, which has:

\relative c' { \tempo 4=92
  \acciaccatura a8\f-> g1(\trill\deprecateddim g16[ a g a] g8[)
  a16]\( g8[ a16(] g8[)^"rall" a16] g8.[\> a-- g--]\) r8\!\fermata
  \bar "|"
  }

near bar 31.


> Can you go into some detail about the nature of the problem?  What
> case was failing for you and how is your version better?

> Are the existing regression tests thorough enough to fail if you
> have oversimplified something?  Do you need to write a new
> regression test so that your case which was handled badly in the
> past does not break again the next time someone modifies this code?

There are no regression tests for articulated MIDI output at present.



-- 
Dr Peter Chubb				        peter.chubb AT nicta.com.au
http://www.ssrg.nicta.com.au          Software Systems Research Group/NICTA

[Dan Eble, 2015-01-12 00:53:11]

Well, if the original author likes it, I'm not going to argue.

[pkx166h, 2015-01-12 19:14:59]

This has been pushed:

author	Tristan Jelacic <Tristanjelacic@gmail.com>	
	Mon, 12 Jan 2015 18:41:33 +0000 (18:41 +0000)
committer	James Lowe <pkx166h@gmail.com>	
	Mon, 12 Jan 2015 19:11:06 +0000 (19:11 +0000)
commit	6802aea5ad26c060c91cdff2c7b206347f58b88d

you can close this Rietveld issue. Thanks for your help.